Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jun 9, 2023

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now on public competitions page: the small glitch before competitions are loaded is fixed

Issues this PR resolves

#916

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Jun 9, 2023

@ihsaan-ullah Is this solve even if there are several pages of competitions?

@ihsaan-ullah
Copy link
Collaborator Author

@ihsaan-ullah Is this solve even if there are several pages of competitions?

It solves the buttons showing for a second before competitions are loaded.
I am going to check the behaviour when we have several pages of competitions

But I think the pagination does not work on https://www.codabench.org/competitions/public/

@Didayolo
Copy link
Member

Didayolo commented Jun 9, 2023

In the past the pagination was working... Maybe there is just not enough competitions to have multiple pages

@ihsaan-ullah
Copy link
Collaborator Author

Then it should be working. Not sure what is the limit in the page

<div class="pagination-nav" hide="{(get_array_length(competitions.results) === competitions.count) || (get_array_length(competitions.results) < 10)}">

I am not sure about the second condition if it is working

(get_array_length(competitions.results) < 10)

@Didayolo Didayolo merged commit b43105a into develop Jun 9, 2023
@Didayolo Didayolo deleted the public_competitions_glitch branch June 9, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants