Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/apps/api/serializers/competitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,18 +337,6 @@ class Meta:
class CompetitionParticipantSerializer(serializers.ModelSerializer):
username = serializers.CharField(source='user.username')
is_bot = serializers.BooleanField(source='user.is_bot')

class Meta:
model = CompetitionParticipant
fields = (
'username',
'is_bot',
)


class CompetitionParticipantWithEmailSerializer(serializers.ModelSerializer):
username = serializers.CharField(source='user.username')
is_bot = serializers.BooleanField(source='user.is_bot')
email = serializers.CharField(source='user.email')

class Meta:
Expand Down
10 changes: 1 addition & 9 deletions src/apps/api/views/competitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
from rest_framework.viewsets import ModelViewSet
from api.serializers.competitions import CompetitionSerializerSimple, PhaseSerializer, \
CompetitionCreationTaskStatusSerializer, CompetitionDetailSerializer, CompetitionParticipantSerializer, \
CompetitionParticipantWithEmailSerializer,\
FrontPageCompetitionsSerializer, PhaseResultsSerializer, CompetitionUpdateSerializer, CompetitionCreateSerializer
from api.serializers.leaderboards import LeaderboardPhaseSerializer, LeaderboardSerializer
from competitions.emails import send_participation_requested_emails, send_participation_accepted_emails, \
Expand Down Expand Up @@ -605,6 +604,7 @@ def get_leaderboard(self, request, pk):

class CompetitionParticipantViewSet(ModelViewSet):
queryset = CompetitionParticipant.objects.all()
serializer_class = CompetitionParticipantSerializer
filter_backends = (DjangoFilterBackend, SearchFilter)
filter_fields = ('user__username', 'user__email', 'status', 'competition')
search_fields = ('user__username', 'user__email',)
Expand All @@ -617,14 +617,6 @@ def get_queryset(self):
qs = qs.select_related('user').order_by('user__username')
return qs

def get_serializer_class(self):

participants_with_email = self.request.query_params.get('participants_with_email', None)
if participants_with_email:
return CompetitionParticipantWithEmailSerializer
else:
return CompetitionParticipantSerializer

def update(self, request, *args, **kwargs):
if request.method == 'PATCH':
if 'status' in request.data:
Expand Down
2 changes: 1 addition & 1 deletion src/apps/profiles/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def get_full_name(self):
return self.name

def __str__(self):
return self.username
return f'{self.username} | {self.email}'

@property
def slug_url(self):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@
if (status && status !== '-') {
filters.status = status
}
filters.participants_with_email = true

CODALAB.api.get_participants(filters)
.done(participants => {
Expand Down