Update organization creation

[joshsmith]

Problem

An organization can be created by a user only if there is an OrganizationInvite that has not been fulfilled yet. That user must be set as the owner of the Organization via an OrganizationMembership.

We should also consider adding something like a created_by_user_id to both Organization and Project to track who originally created it.

Subtasks

• Write migration
• Write model tests
• Update the changesets
• Update controller tests
• Update the controller logic

[snewcomer]

@joshsmith want me to tackle this?

[joshsmith]

@snewcomer moving to low priority along with other tasks in this milestone.

[vishaldeepak]

@joshsmith It seems to me the requirement may be different than what has been specified above. One I can find out is organization already belongs to belongs_to :owner, CodeCorps.User. This is what I understand currently

• Add function in Policy.Organization to accomadate for creation of organization via email. If the user is not an admin but he has provided a code for a unfulfilled OrganizationInvite, he should be allowed to create
• On creation the OrganizationInvite should be fulfilled
• On creation update created_by_user_id
• Remove owner relationship on Organization and instead use OrganizationMembership to track User to a Organization

[joshsmith]

This sounds generally right to me although I would like @begedin to share thoughts. I think we may want some of that behavior contained somewhere else.

[begedin]

The policy changes are tackled through a smaller issue - #1230

[begedin]

@joshsmith I'm not sure about removing owner. We've explicitly added it to simplify things. I'm not even sure we're planning for organization ownership transfer in the foreseeable future, so adding a created_by_user_id might be overthinking it at this point to.

The way I see it, the policy change via #1230 and auto-fulfilment via #1229 is enough to tackle this issue for now.

Once and if we want to make organizations transferable between users, we can add a simple migration to update created_by_user_id using owner_id and modify existing code further.

Anything else would be assuming too much right now, in my opinion.