1286 conversation models #1295
Merged
1286 conversation models #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think I'd specified either |
begedin
force-pushed
the
1286-conversation-models
branch
from
5603b77 to
51b35b4
Compare
joshsmith
force-pushed
the
add-messages
branch
from
2d5c56e to
978300d
Compare
…Part} - included factories - included has_many :conversations in CodeCorps.Message
joshsmith
force-pushed
the
1286-conversation-models
branch
from
51b35b4 to
30c9b07
Compare
joshsmith
approved these changes
Dec 13, 2017
Contributor
|
Coverage went down because factories are unused, but that will change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Setting the base to #1278 for the time being, since it's not merged yet, so reviews can be easier. Base should be changed to develop once #1278 is merged.
This PR adds Conversation and ConversationPart schemas and models, with correct associations with
CodeCorps.Message,CodeCorps.Useras well as each other.I also implemented the factories for the two new models and have added indexes based on what we intend to filter the records by.
References
Fixes #1286
Progress on: https://github.com/code-corps/code-corps-api/milestone/22