Skip to content

Conversation

@joshlory
Copy link
Contributor

Resurrect the changes in PR #529 to draw the underwater overlay without the WebGL shader.

Not clear yet if the shader is causing issues on low-end Chromebooks, but creating this as a WIP PR in case we need it.

@joshlory joshlory requested a review from jmkulwik September 18, 2019 23:31
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #558 into master will increase coverage by 0.02%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage    75.8%   75.83%   +0.02%     
==========================================
  Files          43       43              
  Lines        5378     5396      +18     
==========================================
+ Hits         4077     4092      +15     
- Misses       1301     1304       +3
Impacted Files Coverage Δ
src/js/game/LevelMVC/LevelView.js 84.75% <89.47%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db1d6c...4b47aed. Read the comment docs.

@ajpal ajpal changed the base branch from master to main June 30, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant