Draft
Conversation
LeonardPuettmannKern
requested changes
Sep 15, 2023
Comment on lines
+15
to
+18
| from .numbers import ( | ||
| annotator_split | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
Shouldn't be in this PR
| ```python | ||
| import re | ||
|
|
||
| ATTRIBUTE: str = "headline" #only text attributes |
Contributor
There was a problem hiding this comment.
Change headline to text please.
| @@ -0,0 +1 @@ | |||
| This modules removes certain aspects of the email to focus on the context. The aspects being removed are Sentences starting with "EXTERNAL MAIL", Brackets, that starts with "cid.image", everything after the Disclaimer or until the next Mail in case of response-mails and everything after the signiture in brackets or until the next Mail. No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Typos
Suggested change
| This modules removes certain aspects of the email to focus on the context. The aspects being removed are Sentences starting with "EXTERNAL MAIL", Brackets, that starts with "cid.image", everything after the Disclaimer or until the next Mail in case of response-mails and everything after the signiture in brackets or until the next Mail. | |
| This module removes certain aspects of the email to focus on the context. The aspects being removed are sentences starting with "EXTERNAL MAIL", brackets, that start with "cid.image", everything after the disclaimer or until the next mail in case of response mail, and everything after the signature in brackets or until the next mail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist: