refactor(kimi-web-search): rename tools to snake_case for consistency#20
Open
ckanner wants to merge 2 commits into
Open
refactor(kimi-web-search): rename tools to snake_case for consistency#20ckanner wants to merge 2 commits into
ckanner wants to merge 2 commits into
Conversation
Rename SearchWeb/FetchURL to kimi_search_web/kimi_fetch_url to align with senpi/pi-mono tool naming conventions (snake_case/lowercase). All other builtin and third-party tools use snake_case: - read, write, edit, bash - web_search, apply_patch, multiedit - todowrite, todoread PascalCase (SearchWeb/FetchURL) was inherited from Kimi CLI but is inconsistent with the rest of the extension ecosystem. Refs: code-yeongyu#10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
SearchWeb/FetchURLtokimi_search_web/kimi_fetch_urlto align with senpi/pi-mono tool naming conventions.Problem
The current tool names use PascalCase (
SearchWeb,FetchURL), inherited from Kimi CLI's class names. This is inconsistent with every other tool in the senpi ecosystem:read,write,edit,bashapply_patch,multieditweb_search(anthropic-web-search)todowrite,todoreadSearchWeb,FetchURL(kimi-web-search)Solution
SearchWeb→kimi_search_webFetchURL→kimi_fetch_urlThis makes the tool names consistent with:
pi-websearchusesweb_search)Changes
packages/coding-agent/src/core/extensions/builtin/kimi-web-search/index.tsname,label,description,promptSnippetupdatedChecklist
Migration
Users with
permissionrules forSearchWeb/FetchURLneed to update:Refs: #10
Summary by cubic
Renamed
SearchWebandFetchURLtokimi_search_webandkimi_fetch_urlfor consistent snake_case tool names across senpi/pi-mono, and updated regression tests. Aligns with the naming standard in #10; no schema or behavior changes.permissionrules or references:SearchWeb→kimi_search_web,FetchURL→kimi_fetch_url.Written for commit ec1be28. Summary will update on new commits. Review in cubic