Conversation
raphael-goetz
requested changes
Nov 13, 2025
Member
raphael-goetz
left a comment
raphael-goetz
left a comment
There was a problem hiding this comment.
The code looks great. The missing thing would be a constructor for the reader. One for creating it with just the path (setting the default values for all the other fields) and a second one where you configure each field.
Also the fields version and accepted_features are still unsused.
MecryTv
force-pushed
the
135-reimplement-reader
branch
from
a3674ac to
9290c1b
Compare
raphael-goetz
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #135