Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds alias and displayMessage fields to all definition files and renames all occurrences of "ARRAY" to "LIST" throughout the codebase. The changes aim to improve searchability and user-facing display messages for runtime definitions and data types.
Key changes:
- Added
aliasanddisplayMessagefields to runtime definitions, data types, and flow types - Renamed data type identifier from "ARRAY" to "LIST" across all definitions
- Updated
tucanadependency from0.0.40to0.0.41in Cargo.toml
Reviewed Changes
Copilot reviewed 132 out of 133 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| definitions/standard/runtime_definition/text/*.proto.json | Added alias/displayMessage to text operations |
| definitions/standard/runtime_definition/number/*.proto.json | Added alias/displayMessage to number operations |
| definitions/standard/runtime_definition/array/*.proto.json | Renamed array to list, added alias/displayMessage |
| definitions/standard/runtime_definition/boolean/*.proto.json | Added alias/displayMessage to boolean operations |
| definitions/standard/runtime_definition/control/*.proto.json | Added alias/displayMessage to control flow operations |
| definitions/standard/runtime_definition/object/*.proto.json | Added alias/displayMessage to object operations |
| definitions/standard/data_type/**/*.proto.json | Added alias/displayMessage, renamed ARRAY to LIST |
| definitions/http/**/*.proto.json | Added alias/displayMessage to HTTP-related definitions |
| Cargo.toml/Cargo.lock | Updated tucana dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/boolean/std_boolean_from_text.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_sin.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_map.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_at.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_index_of.proto.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 132 out of 133 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/text/std_text_from_ascii.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_push.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_at.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_filter.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_to_ascii.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_from_ascii.proto.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
….proto.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
…to.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 132 out of 133 changed files in this pull request and generated 20 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/array/std_array_index_of.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_join.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_split.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_split.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_sort_reverse.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_sum.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_sin.proto.json
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_max.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/array/std_array_sort.proto.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 132 out of 133 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/text/std_text_as_bytes.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_as_bytes.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_as_bytes.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_chars.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_chars.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_chars.proto.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 132 out of 133 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/object/std_object_keys.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/object/std_object_keys.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/object/std_object_keys.proto.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 132 out of 133 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "displayMessage": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "On ${method} request to ${route}" |
There was a problem hiding this comment.
The displayMessage references ${method} and ${route}, but these identifiers don't match the actual setting identifiers defined in the file (HTTP_METHOD and HTTP_URL). This will likely cause display issues.
| "content": "On ${method} request to ${route}" | |
| "content": "On ${HTTP_METHOD} request to ${HTTP_URL}" |
| "alias": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "to text;string;format number;boolean;logic;std;as;text" |
There was a problem hiding this comment.
The alias "format number" in this boolean conversion function is misleading - it suggests number formatting rather than boolean-to-text conversion.
| "alias": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "text;char;literal;string" | ||
| } | ||
| ], | ||
| "displayMessage": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "Text" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "text;char;literal;string" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Text" | |
| } | |
| ], | |
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "text;char;literal;string" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Text" | |
| } | |
| ], |
| "alias": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "number;integer;float;double;long" | ||
| } | ||
| ], | ||
| "displayMessage": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "Number" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "number;integer;float;double;long" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Number" | |
| } | |
| ], | |
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "number;integer;float;double;long" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Number" | |
| } | |
| ], |
| "alias": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "bool;boolean;bit" | ||
| } | ||
| ], | ||
| "displayMessage": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "Boolean" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "bool;boolean;bit" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Boolean" | |
| } | |
| ], | |
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "bool;boolean;bit" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Boolean" | |
| } | |
| ], |
| "alias": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "object;struct;data" | ||
| } | ||
| ], | ||
| "displayMessage": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "Object" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Inconsistent indentation: using tabs in some places and spaces in others. The file should use consistent indentation throughout.
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "object;struct;data" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Object" | |
| } | |
| ], | |
| "alias": [ | |
| { | |
| "code": "en-US", | |
| "content": "object;struct;data" | |
| } | |
| ], | |
| "displayMessage": [ | |
| { | |
| "code": "en-US", | |
| "content": "Object" | |
| } | |
| ], |
| "displayMessage": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "cos(${radians})" |
There was a problem hiding this comment.
The displayMessage incorrectly references parameter ${radians}, but the parameter is named value (line 8). This will cause the display message to not interpolate correctly.
| "displayMessage": [ | ||
| { | ||
| "code": "en-US", | ||
| "content": "tan(${radians})" |
There was a problem hiding this comment.
The displayMessage incorrectly references parameter ${radians}, but the parameter is named value (line 8). This will cause the display message to not interpolate correctly.
Resolves: #151
aliasanddisplayMessageto every definition