Conversation
There was a problem hiding this comment.
Pull request overview
This pull request aims to improve translations and consistency across standard runtime definition files for text, number, and object operations. The changes primarily focus on consolidating redundant documentation, standardizing terminology (e.g., replacing "string" with "text", "substring" with "subtext"), improving display messages with better capitalization, and converting indentation from spaces to tabs.
Key changes include:
- Removal of redundant documentation fields by consolidating content into description fields
- Terminology standardization across all text-related functions
- Display message improvements for better readability
- One functional change: marking
std::number::divideasthrowsError: true
Reviewed changes
Copilot reviewed 111 out of 125 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| std_text_*.proto.json (25 files) | Consolidated documentation, standardized "text"/"subtext" terminology, improved display messages |
| std_object_*.proto.json (4 files) | Consolidated documentation, simplified descriptions, improved display messages |
| std_number_*.proto.json (41 files) | Consolidated documentation, improved display messages with better capitalization, marked divide as throwing errors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/number/std_number_is_positive.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_is_less.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_is_greater.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_chars.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_append.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/text/std_text_replace.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_sinh.proto.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 111 out of 125 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
definitions/standard/runtime_definition/number/std_number_cosh.proto.json
Outdated
Show resolved
Hide resolved
definitions/standard/runtime_definition/number/std_number_sinh.proto.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 111 out of 125 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolves: #180