Conversation
nicosammito
requested changes
Jan 8, 2026
Contributor
nicosammito
left a comment
There was a problem hiding this comment.
You can not use
"dataTypeIdentifier": {
"dataTypeIdentifier": "OBJECT"
}
because the data type of Object is a generic Type. You need to provide a generic mapper
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds generic type support to OBJECT-related definitions by introducing generic keys and type mappers. The changes ensure that OBJECT types can properly represent their generic type parameters across runtime and data type definitions.
- Adds generic type mappings with key "O" (or "T" for base OBJECT) to enable type parameterization
- Updates runtime function definitions (size, set, keys, contains_key) to properly declare generic parameters
- Refactors data type definitions to use generic type structures and removes redundant parentType rules
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| std_object_size.proto.json | Adds generic type "O" with mapper to OBJECT parameter and declares it in genericKeys |
| std_object_set.proto.json | Adds generic type "O" with mapper to OBJECT parameter and adds "O" to existing genericKeys alongside "I" |
| std_object_keys.proto.json | Adds generic type "O" with mapper to OBJECT parameter and declares it in genericKeys |
| std_object_contains_key.proto.json | Adds generic type "O" with mapper to OBJECT parameter and declares it in genericKeys |
| object.proto.json | Introduces base generic type "T" with parentType rule and declares it in genericKeys |
| http_response.proto.json | Updates body field to use generic OBJECT structure and removes redundant parentType rule |
| http_request.proto.json | Updates body field to use generic OBJECT structure and removes redundant parentType rule |
| http_header_entry.proto.json | Removes redundant parentType rule (no generic types needed) |
| rest_adapter_input.proto.json | Updates body field to use generic OBJECT structure, removes parentType rule, and adds "O" to genericKeys |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicosammito
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #203