Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds display icons to runtime definitions across multiple groups, resolving issue #188. Icons are assigned based on functional groups to provide visual differentiation in the UI.
- Added
displayIconfield to all runtime definition files - Icons are grouped by functionality (text, math, arrays, objects, etc.)
- Consistent JSON formatting maintained across all changes
Reviewed changes
Copilot reviewed 111 out of 111 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Text definitions (30 files) | Added tabler:abc icon for text manipulation operations |
| Object definitions (4 files) | Added tabler:cube icon for object operations |
| Number definitions (43 files) | Added tabler:math-function icon for mathematical operations |
| HTTP definitions (3 files) | Added tabler:world-www icon for HTTP-related operations |
| Control definitions (4 files) | Added tabler:arrow-iteration icon for control flow operations |
| Boolean definitions (6 files) | Added tabler:file-digit icon for boolean operations |
| Array definitions (30 files) | Added tabler:list icon for array operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicosammito
requested changes
Jan 7, 2026
Contributor
nicosammito
left a comment
nicosammito
left a comment
There was a problem hiding this comment.
Generally speaking, we should use file-.... icons for flow types and not for functions. Otherwise I'm fine with the picked icons but not for control functions. The icon for each control function should be more explaining. Please choose a more describing icon for each control function.
nicosammito
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #188
I set the icons based on the groups (one icon for math, one icon for text...)