Merged
Conversation
Taucher2003
requested changes
Dec 16, 2025
Member
Taucher2003
left a comment
There was a problem hiding this comment.
It looks like the messages are the same for both aquila and sagittarius, so they should be inside shared. That way we don't have to duplicate them. The services should stay in the respective protocol.
62cfac9 to
168e424
Compare
Signed-off-by: Dario Pranjic <96529060+Knerio@users.noreply.github.com>
168e424 to
8198d77
Compare
Taucher2003
reviewed
Dec 16, 2025
raphael-goetz
approved these changes
Dec 17, 2025
Member
Author
|
Can we merge this?? |
Contributor
If its approved you can merge it |
nicosammito
requested changes
Dec 18, 2025
e6b59f9 to
3b5222c
Compare
nicosammito
approved these changes
Dec 19, 2025
Taucher2003
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #174