Skip to content

Labels for Applications#608

Merged
dragos1195 merged 8 commits intodevelopfrom
476
Aug 14, 2024
Merged

Labels for Applications#608
dragos1195 merged 8 commits intodevelopfrom
476

Conversation

@dragos1195
Copy link
Copy Markdown
Contributor

No description provided.

@dragos1195 dragos1195 added the enhancement 🚀 New feature or request label Aug 13, 2024
@dragos1195 dragos1195 self-assigned this Aug 13, 2024
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@radulescuandrew
Copy link
Copy Markdown
Contributor

radulescuandrew commented Aug 13, 2024

image @dragos1195 Selectezi o optiune si dai enter, se adauga pas nou la "Pasi pentru adaugare"

Comment thread backend/src/modules/application/dto/create-application.dto.ts
name: applicationWithDetails.applicationLabel_name,
};

delete applicationWithDetails.applicationLabel_id;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nu putem face queryul direct cu id si name ca aliasuri ca sa nu mai facem delete-uri?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este getRawOne, n-am cum sa le scot direct in object.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, am inteles ca vrei sa le pui intr-un obiect direct.

Deci chiar daca facem

        'applicationLabel.id as "applicationLabelId"',
        'applicationLabel.name as "applicationLabelName"',

Tot trebuie sa le stergi apoi din applicationWithDetails cele 2 props.

@dragos1195 Totusi, mai lipseste applicationLabel din interfata IOngApplicationDetails

Comment thread frontend/src/pages/application/ApplicationWithOngList.tsx Outdated
Comment thread frontend/src/services/nomenclature/Nomenclature.queries.ts
Comment thread frontend/src/pages/apps-store/components/ApplicationListTable.tsx
@radulescuandrew
Copy link
Copy Markdown
Contributor

@dragos1195 E intr-adevar ciudat ca avem TTL 5 minute. Putem face break la cache cand se adauga o optiune noua await this.cacheManager.reset(); https://docs.nestjs.com/techniques/caching

@radulescuandrew
Copy link
Copy Markdown
Contributor

@dragos1195 Incepi sa scrii, si cand treci peste 30 caractere nu-ti mai apare "Adauga optiunea" pentru ca a picat validatorul dar nu apare nicio eroare si e f confusing. Am stat mult sa-mi dau seama ce se intampla.

Comment thread backend/src/shared/controllers/nomenclatures.controller.ts Outdated
@dragos1195 dragos1195 merged commit 075f533 into develop Aug 14, 2024
@dragos1195 dragos1195 deleted the 476 branch August 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SuperAdmin] Implement new labeling system for apps [Applications] Add a new label for on-demand applications

2 participants