Skip to content

refactor: Renames user roles, improves security #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cbaudouinjr wants to merge 14 commits into from
Closed

refactor: Renames user roles, improves security #345

cbaudouinjr wants to merge 14 commits into from

Conversation

@cbaudouinjr
Copy link
Member

@cbaudouinjr cbaudouinjr commented Sep 12, 2020 •
edited
Loading

  • Renames admin->Director, admin_limited_access->Organizer, event_tracking->Volunteer
  • Redesigns Volunteer manage area
  • Prevents Volunteers from seeing Dashboard (hides hackathon application numbers and other sensitive statistics, also simplifies the UI for Voluneteers who are usually first-time users)

Volunteer sidebar:
image

  • Refactors underlying Manage security (security on a per-feature basis)
  • Staff members trying to access a restricted area will be redirected to their default Manage area rather than being kicked out of Manage (Dashboard for Directors, Organizers and Check-in for Volunteers)

closes #242

houndci-bot
houndci-bot reviewed Sep 12, 2020
View reviewed changes
@cbaudouinjr
Copy link
Member Author

cbaudouinjr commented Sep 12, 2020 •
edited by peterkos
Loading

Known issues:

  • For volunteer role, "Check-in" button on sidebar is not highlighted by default

image

@cbaudouinjr cbaudouinjr linked an issue Sep 12, 2020 that may be closed by this pull request
Tweak roles: Add "Director" position, remove "Admin" #242
Closed
@peterkos
Copy link
Contributor

peterkos commented Sep 19, 2020 •
edited
Loading

  • Add'l bug: duplicate item for "check in" on director role maybe?

JeremyRudman and others added 2 commits September 19, 2020 21:03
@JeremyRudman
fix(sidebar): fixed UI problems for diffrent roles
b5ad3b8 
removed the duplicate checkin button for orginizers and had checkin page defaut to be highlighted for volenteers
@cbaudouinjr
Merge branch '2.0' into hm-242
3f2a30c
@cbaudouinjr cbaudouinjr marked this pull request as ready for review September 20, 2020 04:37
peterkos
peterkos approved these changes Sep 20, 2020
View reviewed changes
docs/messages.md
* **Bust list** — Becoming a passenger or bus captain

These messages are sent immediatley upon an applicant entering the given state. For example, when an admin marks someone as "accepted," they will immediately receive any automated messages associated with the "Questionnaire Status: Accepted" event.
These messages are sent immediatley upon an applicant entering the given state. For example, when a staff member marks someone as "accepted," they will immediately receive any automated messages assocaited with the "Questionnaire Status: Accepted" event.
Copy link
Contributor

@peterkos peterkos Sep 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to define "staff member" somewhere in the docs; I'll put this in 2.0 migration guide for now

@peterkos peterkos closed this Sep 20, 2020
@peterkos
Copy link
Contributor

peterkos commented Sep 20, 2020

Merged in 58b5849 due to GitHub glitch in merge conflict; will address fixes in new PR

@peterkos peterkos mentioned this pull request Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterkos peterkos peterkos approved these changes

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tweak roles: Add "Director" position, remove "Admin"

5 participants

@cbaudouinjr @peterkos @houndci-bot @JeremyRudman