Skip to content

Conversation

@peterkos
Copy link
Contributor

@peterkos peterkos commented Nov 14, 2020

Fixes #380

Fixes scrolling on sidebar mobile view under manage

image

@peterkos peterkos added the 2.1 label Nov 14, 2020
@peterkos peterkos self-assigned this Nov 14, 2020
Signed-off-by: Peter Kos <pkos91@icloud.com>
Signed-off-by: Peter Kos <pkos91@icloud.com>
@peterkos peterkos marked this pull request as draft November 15, 2020 01:44
Sidebar width is better
Toggle button fills height of navbar

Signed-off-by: Peter Kos <pkos91@icloud.com>
@peterkos peterkos marked this pull request as ready for review November 15, 2020 02:42
Copy link
Member

@cbaudouinjr cbaudouinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterkos peterkos removed the request for review from JeremyRudman November 15, 2020 02:42
@peterkos
Copy link
Contributor Author

Credit to @cbaudouinjr and @sjmiller4rit for the emotional support fixing this issue

@cbaudouinjr cbaudouinjr merged commit 57098dc into 2.1 Nov 15, 2020
@cbaudouinjr cbaudouinjr deleted the hm-380 branch November 15, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile sidebar unable to scroll; "Sign out" too close to hamburger menu

3 participants