refactored keypair handling#5
Open
c33s wants to merge 1 commit into
Open
Conversation
c33s
force-pushed
the
feature/public-from-private
branch
from
3d6a132 to
db9d487
Compare
c33s
changed the title
Author
|
noticed keys are generated with windows line ending. adding normalization. |
c33s
force-pushed
the
feature/public-from-private
branch
from
db9d487 to
4438d84
Compare
c33s
force-pushed
the
feature/public-from-private
branch
from
4438d84 to
c6621d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
SshKeyPair: added typehintsSshPrivateKey: addedgetPublicKeyMethodSshPublicKey: addedfromPrivateKey()MethodSshPublicKey: addedsetComment()MethodChanged
SshKey:getKeyData()has nowopensshas default formatSshKeyPair: changed constructor signature, switched public with private to allow tonullas public keySshKeyPair: increased default bit size to 4096SshPublicKey:constructorto allow to set the comment & added typehintsas i change the constructor and if you want to follow semver this should be a major version upgrade. the code could be changed to not introduce a bc break but it would make more sense to do this.
also i added typehints in some functions https://secure.php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration which would require php7.