-
Notifications
You must be signed in to change notification settings - Fork 5
Update Backport.System.Threading.Lock; Revert LangVersion to latest #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Backport.System.Threading.Lock; Revert LangVersion to latest #101
Conversation
WalkthroughThe changes in this pull request primarily involve updates to the solution and project configuration files within the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (3)Directory.Packages.props (1)
The version bump from 2.0.5 to 2.0.7 follows semantic versioning, suggesting backward-compatible changes. However, since this is a critical threading library, please ensure there are no breaking changes or security fixes. Directory.Build.props (2)
Changing from 'preview' to 'latest' is a good practice for production code as it ensures we're using stable language features rather than potentially unstable preview features.
Since we're moving from 'preview' to 'latest', we should ensure no preview language features are being used that might break the build. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This will be part of the RTM currently in progress. |
|
@gimlichael I believe you missed the part reverting LangVersion from preview to latest. It was needed before for locking on a System.Threading.Lock, but now it works with 'latest'. |
|
Thanks for the heads-up .. it will be fixed at some point in time .. not so critical, but good with proper housekeeping. |
Summary by CodeRabbit
New Features
Updates
Backport.System.Threading.Lockpackage version for enhanced functionality.