Skip to content

⚗️ gha seems to have problems with .net9rc1 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gimlichael wants to merge 3 commits into from
Closed

⚗️ gha seems to have problems with .net9rc1 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
655f815
:alembic: gha seems to have problems with .net9rc1 when running:
gimlichael Sep 12, 2024
8df266f
:pencil2: forgot to remove condition for net9
gimlichael Sep 12, 2024
6f06792
:arrow_down: downgrade all net9rc1 to preview7
gimlichael Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .github/workflows/pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,25 @@ jobs:
- name: Checkout
uses: codebeltnet/git-checkout@v1

- name: Install .NET
uses: codebeltnet/install-dotnet@v1
# - name: Install .NET
# uses: codebeltnet/install-dotnet@v1
# with:
# includePreview: true

- name: 6.0.x
uses: actions/setup-dotnet@v4
with:
includePreview: true
dotnet-version: 6.0.x
- name: 8.0.x
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x

- name: 9.0.100-preview.7.24407.12
uses: actions/setup-dotnet@v4
with:
dotnet-version: 9.0.100-preview.7.24407.12
dotnet-quality: preview

- name: Install .NET Tool - Report Generator
uses: codebeltnet/dotnet-tool-install-reportgenerator@v1
Expand Down
2 changes: 1 addition & 1 deletion ...atters.Newtonsoft.Json/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</PropertyGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="9.0.0-rc.1.24452.1" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="9.0.0-preview.7.24406.2" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down
4 changes: 2 additions & 2 deletions src/Cuemon.Extensions.DependencyInjection/Cuemon.Extensions.DependencyInjection.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
</PropertyGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="9.0.0-preview.7.24405.7" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.0-preview.7.24405.7" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down
2 changes: 1 addition & 1 deletion src/Cuemon.Extensions.Hosting/Cuemon.Extensions.Hosting.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0-preview.7.24405.7" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down
2 changes: 1 addition & 1 deletion src/Cuemon.Extensions.Net/Cuemon.Extensions.Net.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Microsoft.Extensions.Http" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Http" Version="9.0.0-preview.7.24405.7" />
Copy link

@coderabbitai coderabbitai bot Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the reason for the rollback and ensure compatibility through testing.

The change in the package version from 9.0.0-rc.1.24431.7 to 9.0.0-preview.7.24405.7 appears to be a rollback from a release candidate to a preview version. Preview versions are typically less stable than release candidates and may introduce breaking changes.

Please provide clarification on the reason for this rollback. Additionally, ensure that the preview version is compatible with the rest of the application and its dependencies by conducting thorough testing to identify any potential issues.

</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down
2 changes: 1 addition & 1 deletion src/Cuemon.Extensions.Text.Json/Cuemon.Extensions.Text.Json.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="System.Text.Json" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="System.Text.Json" Version="9.0.0-preview.7.24405.7" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down
2 changes: 1 addition & 1 deletion ...mon.Extensions.Xunit.Hosting.AspNetCore/Cuemon.Extensions.Xunit.Hosting.AspNetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="9.0.0-rc.1.24452.1" />
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="9.0.0-preview.7.24406.2" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down
10 changes: 5 additions & 5 deletions src/Cuemon.Extensions.Xunit.Hosting/Cuemon.Extensions.Xunit.Hosting.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
</PropertyGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="9.0.0-rc.1.24431.7" />
<PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0-preview.7.24405.7" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="9.0.0-preview.7.24405.7" />
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="9.0.0-preview.7.24405.7" />
<PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="9.0.0-preview.7.24405.7" />
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="9.0.0-preview.7.24405.7" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down
2 changes: 1 addition & 1 deletion test/Cuemon.Data.Tests/Cuemon.Data.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net9'))">
<PackageReference Include="Microsoft.Data.Sqlite" Version="9.0.0-rc.1.24451.1" />
<PackageReference Include="Microsoft.Data.Sqlite" Version="9.0.0-preview.7.24405.3" />
</ItemGroup>

<ItemGroup Condition="$(TargetFramework.StartsWith('net8'))">
Expand Down