-
Notifications
You must be signed in to change notification settings - Fork 0
V8.4.0/migrate from cuemon #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8eccf43
d319298
1a6f4f1
d83b826
3747d42
2c492e6
07145be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| $version = minver -i -t v -v w | ||
| docfx metadata docfx.json | ||
| docker buildx build -t yourbranding/classlibrary1:$version --platform linux/arm64,linux/amd64 --load -f Dockerfile.docfx . | ||
| docker buildx build -t jcr.codebelt.net/geekle/globalization-docfx:$version --platform linux/arm64,linux/amd64 --load -f Dockerfile.docfx . | ||
| get-childItem -recurse -path api -include *.yml, .manifest | remove-item | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| $version = minver -i -t v -v w | ||
| docker tag classlibrary1-docfx:$version yourbranding/classlibrary1:$version | ||
| docker push yourbranding/classlibrary1:$version | ||
| docker tag globalization-docfx:$version jcr.codebelt.net/geekle/globalization-docfx:$version | ||
| docker push jcr.codebelt.net/geekle/globalization-docfx:$version |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| uid: Codebelt.Extensions.Globalization | ||
| summary: *content | ||
| --- | ||
| The `Codebelt.Extensions.Globalization` namespace contains extension methods that is an addition to the `System.Globalization` namespace. | ||
|
|
||
| [!INCLUDE [availability-default](../../includes/availability-default.md)] | ||
|
|
||
| Complements: [System.Globalization namespace](https://docs.microsoft.com/en-us/dotnet/api/system.globalization) 🔗 | ||
|
|
||
| ### Extension Methods | ||
|
|
||
| |Type|Ext|Methods| | ||
| |--:|:-:|---| | ||
| |CultureInfo|⬇️|`UseNationalLanguageSupport`| | ||
|
|
||
| ### CSharp Example | ||
|
|
||
| ```csharp | ||
| var danishCultureIcu = new CultureInfo("da-dk", false); | ||
| var danishCultureNls = new CultureInfo("da-dk", false).UseNationalLanguageSupport(); | ||
|
|
||
| // danishCultureIcu outputs dd.MM.yyyy from danishCultureIcu.DateTimeFormat.ShortDatePattern | ||
| // danishCultureNls outputs dd-MM-yyyy from danishCultureNls.DateTimeFormat.ShortDatePattern | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,15 @@ | ||
| --- | ||
| uid: frontpage-md | ||
| title: ClassLibrary1 | ||
| title: Extensions for Globalization by Codebelt | ||
| --- | ||
| # ClassLibrary1 | ||
|  | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Issue: Image file not found The specified image 🔗 Analysis chainLGTM: Image added for visual representation. The addition of an image enhances the visual appeal of the documentation. This is a good improvement. Please verify that the image file exists at the specified path: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the existence of the project logo image.
# Test: Check if the image file exists
if fd -p "images/128x128.png" > /dev/null; then
echo "Image file found."
else
echo "Image file not found. Please ensure it's placed in the correct location."
fi
Length of output: 119 Script: #!/bin/bash
# Description: Verify the existence of the project logo image.
# Test: Check if the image file exists using fd
fd "128x128.png" ./images --type f --max-depth 1 > /dev/null
if [ $? -eq 0 ]; then
echo "Image file found."
else
echo "Image file not found. Please ensure it's placed in the correct location."
fi
Length of output: 320 Script: #!/bin/bash
# Description: Check for the 'images' directory and locate '128x128.png' if necessary.
# Check if the 'images' directory exists
if [ -d "./images" ]; then
echo "Directory './images' exists."
# Check if the image file exists within the 'images' directory
if [ -f "./images/128x128.png" ]; then
echo "Image file '128x128.png' found in './images/'."
else
echo "Image file '128x128.png' not found in './images/'."
fi
else
echo "Directory './images' does not exist. Searching for '128x128.png' in the repository."
# Search for the image file in the repository
image_path=$(fd "128x128.png" . --type f --max-depth 10)
if [ -n "$image_path" ]; then
echo "Image file found at: $image_path"
else
echo "Image file '128x128.png' not found in the repository."
fi
fi
Length of output: 407 |
||
|
|
||
| Landing page for ClassLibrary1. | ||
| # Extensions for Globalization by Codebelt | ||
|
|
||
| Originally, this project was part of **Cuemon for .NET**, but with the forthcoming release of .NET 9 (and what resembled circular reference dependencies), it was split into its own project. | ||
|
|
||
| This project is now part of [Extensions for Globalization API by Codebelt](https://github.com/codebeltnet/globalization). | ||
|
|
||
| [Cuemon for .NET](https://www.cuemon.net/) will pursue its original purpose; providing an addition/complement/sidecar to Microsoft .NET platform. | ||
|
|
||
| Proceed to the [docs](/api/Codebelt.Extensions.Globalization.html) to learn more about the capabilities of this project. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,11 @@ | ||
| # NuGet Packages | ||
|
|
||
| This is a list of all NuGet packages from **ClassLibrary1** that is publicly available on [NuGet.org](https://www.nuget.org/packages?q=ClassLibrary1); the packages here are listed alphabetically and are available in preview-, rc- and production-ready versions. | ||
| This is a list of all NuGet packages from **Extensions for Globalization API by Codebelt** that is publicly available on [NuGet.org](https://www.nuget.org/packages?q=Codebelt.Extensions); the packages here are listed alphabetically and are available in preview-, rc- and production-ready versions. | ||
|
|
||
| ## 📦 Standalone Packages | ||
| ### 📦 Standalone Packages | ||
|
|
||
| Provides a focused API for ... | ||
| Provides a focused API for RESTful versioning. | ||
|
|
||
| |Package|vNext|Stable|Downloads| | ||
| |:--|:-:|:-:|:-:| | ||
| | [ClassLibrary1](https://www.nuget.org/packages/ClassLibrary1/) |  |  |  | | ||
|
|
||
| ## 🏭 Productivity Packages | ||
|
|
||
| Provides a convenient set of default API additions for ... | ||
|
|
||
| |Package|vNext|Stable|Downloads| | ||
| |:--|:-:|:-:|:-:| | ||
| | [ClassLibrary1.App](https://www.nuget.org/packages/ClassLibrary1.App/) |  |  |  | | ||
| | [Codebelt.Extensions.Globalization](https://www.nuget.org/packages/Codebelt.Extensions.Globalization/) |  |  |  | |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| - name: ClassLibrary1 API | ||
| href: api/ClassLibrary1.html | ||
| - name: Globalization API | ||
| href: api/Codebelt.Extensions.Globalization.html | ||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification The new API documentation file
🔗 Analysis chainLGTM! The TOC changes align with the rebranding effort. The updates to the table of contents accurately reflect the migration from "ClassLibrary1" to "Codebelt.Extensions.Globalization". This change is consistent with the PR objectives and the overall rebranding effort. To ensure consistency across the documentation, let's verify that all references to the old name have been updated: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any remaining references to ClassLibrary1 in documentation files
# Test: Search for "ClassLibrary1" in all documentation files
# Expect: No occurrences of "ClassLibrary1" in .md, .html, or .yml files
rg --type md --type html --type yaml "ClassLibrary1" .
# Test: Verify that the new API documentation file exists
# Expect: File should exist
test -f "api/Codebelt.Extensions.Globalization.html" && echo "New API doc exists" || echo "New API doc missing"
Length of output: 156 |
||
| - name: NuGet | ||
| href: packages | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -374,4 +374,7 @@ FodyWeavers.xsd | |
| *.code-workspace | ||
|
|
||
| # Strong-Name Key | ||
| *.snk | ||
| *.snk | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Action Required: Missing Documentation for SNK Files While
🔗 Analysis chainApproved: Ignoring Strong Name Key files. Adding To ensure this doesn't affect the build process, please verify that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Verify if there are any remaining .snk files in the repository
snk_files=$(fd -e snk)
if [ -n "$snk_files" ]; then
echo "Warning: Found .snk files that are not ignored:"
echo "$snk_files"
else
echo "No .snk files found in the repository."
fi
# Check if there are instructions for handling SNK files
readme_content=$(cat README.md 2>/dev/null || echo "README.md not found")
if echo "$readme_content" | grep -qi "snk\|strong name key"; then
echo "README.md contains information about SNK files."
else
echo "Warning: README.md does not mention SNK files or Strong Name Keys."
fi
Length of output: 478 Script: #!/bin/bash
# Verify if there are any remaining .snk files in the repository
snk_files=$(fd -e snk)
if [ -n "$snk_files" ]; then
echo "Warning: Found .snk files that are not ignored:"
echo "$snk_files"
else
echo "No .snk files found in the repository."
fi
# Check if there are instructions for handling SNK files
readme_content=$(cat README.md 2>/dev/null || echo "README.md not found")
if echo "$readme_content" | grep -qi "snk\|strong name key"; then
echo "README.md contains information about SNK files."
else
echo "Warning: README.md does not mention SNK files or Strong Name Keys."
fi
Length of output: 5014 |
||
|
|
||
| # Tooling | ||
| /tooling/gse/Surrogates | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| Version 8.4.0 | ||
| Availability: .NET 8, .NET 6 and .NET Standard 2.0 | ||
|
|
||
| # ALM | ||
| - CHANGED Dependencies to latest and greatest with respect to TFMs | ||
|
|
||
| # Breaking Changes | ||
| - CHANGED CultureInfoExtensions class in the Codebelt.Extensions.Globalization namespace to use Codebelt.Extensions.YamlDotNet assembly instead of YAML support from Cuemon.Extensions.YamlDotNet assembly | ||
|
|
||
| Version 8.3.2 | ||
| Availability: .NET 8, .NET 6 and .NET Standard 2.0 | ||
|
|
||
| # ALM | ||
| - REMOVED Support for TFM .NET 7 (STS) | ||
|
|
||
| Version 8.3.0 | ||
| Availability: .NET 8, .NET 7, .NET 6 and .NET Standard 2.0 | ||
|
|
||
| # Improvements | ||
| - CHANGED CultureInfoExtensions class in the Codebelt.Extensions.Globalization namespace to use Cuemon.Extensions.YamlDotNet assembly instead of legacy YAML support in Cuemon.Core assembly | ||
| - CHANGED CultureInfoSurrogate class in the Codebelt.Extensions.Globalization namespace to use Cuemon.Extensions.YamlDotNet assembly instead of legacy YAML support in Cuemon.Core assembly | ||
| - CHANGED tooling/gse to use Cuemon.Extensions.YamlDotNet assembly instead of legacy YAML support in Cuemon.Core assembly | ||
|
|
||
| Version 8.2.0 | ||
| Availability: .NET 8, .NET 7, .NET 6 and .NET Standard 2.0 | ||
|
|
||
| # ALM | ||
| - CHANGED Dependencies to latest and greatest with respect to TFMs | ||
|
|
||
| Version: 8.1.0 | ||
| Availability: .NET 8, .NET 7, .NET 6 and .NET Standard 2.0 | ||
|
|
||
| # ALM | ||
| - CHANGED Dependencies to latest and greatest with respect to TFMs | ||
|
|
||
| Version: 8.0.1 | ||
| Availability: .NET 8, .NET 7, .NET 6 and .NET Standard 2.0 | ||
|
|
||
| # ALM | ||
| - CHANGED Dependencies to latest and greatest with respect to TFMs | ||
|
|
||
| Version: 8.0.0 | ||
| Availability: .NET 8, .NET 7, .NET 6 and .NET Standard 2.0 | ||
|
|
||
| # ALM | ||
| - ADDED TFM for net8.0 | ||
| - CHANGED Dependencies to latest and greatest with respect to TFMs | ||
|
|
||
| # Improvements | ||
| - ADDED tooling/gse to the solution folder that is used for extracting NLS surrogates; this was done to mitigate the original design decision that was most [unfortunate](https://github.com/gimlichael/Cuemon/commit/71ff4f9ecb95897170aab1e6ba894c320ae095bd) | ||
| - gse stands for globalization surrogates extractor | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| ## About | ||
|
|
||
| An open-source project (MIT license) that targets and complements the [System.Globalization](https://github.com/dotnet/runtime/tree/main/src/libraries/System.Private.CoreLib/src/System/Globalization) namespace. It aims to provide a way to favor National Language Support (NLS) over International Components for Unicode (ICU). | ||
|
|
||
| It is, by heart, free, flexible and built to extend and boost your agile codebelt. | ||
|
|
||
| ## **Codebelt.Extensions.Globalization** for .NET | ||
|
|
||
| The `Codebelt.Extensions.Globalization` namespace contains extension methods that is an addition to the `System.Globalization` namespace. | ||
|
|
||
| More documentation available at our documentation site: | ||
|
|
||
| - [Codebelt.Extensions.Globalization](https://globalization.codebelt.net/api/Codebelt.Extensions.Globalization.html) 🔗 | ||
|
|
||
| ### CSharp Example | ||
|
|
||
| ```csharp | ||
| var danishCultureIcu = new CultureInfo("da-dk", false); | ||
| var danishCultureNls = new CultureInfo("da-dk", false).UseNationalLanguageSupport(); | ||
|
|
||
| // danishCultureIcu outputs dd.MM.yyyy from danishCultureIcu.DateTimeFormat.ShortDatePattern | ||
| // danishCultureNls outputs dd-MM-yyyy from danishCultureNls.DateTimeFormat.ShortDatePattern | ||
| ``` |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,32 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | |||||
|
|
||||||
| For more details, please refer to `PackageReleaseNotes.txt` on a per assembly basis in the `.nuget` folder. | ||||||
|
|
||||||
| ## [Unreleased] - TBD | ||||||
| ## [8.4.0] - 2024-09-28 | ||||||
|
|
||||||
| ### Changed | ||||||
|
|
||||||
| - CultureInfoExtensions class in the Codebelt.Extensions.Globalization namespace to use Codebelt.Extensions.YamlDotNet assembly instead of YAML support from Cuemon.Extensions.YamlDotNet assembly | ||||||
|
|
||||||
| ## [8.3.0] - 2024-04-09 | ||||||
|
|
||||||
| ### Changed | ||||||
|
|
||||||
| - CultureInfoExtensions class in the Codebelt.Extensions.Globalization namespace to use Cuemon.Extensions.YamlDotNet assembly instead of legacy YAML support in Cuemon.Core assembly | ||||||
| - CultureInfoSurrogate class in the Codebelt.Extensions.Globalization namespace to use Cuemon.Extensions.YamlDotNet assembly instead of legacy YAML support in Cuemon.Core assembly | ||||||
| - tooling/gse to use Cuemon.Extensions.YamlDotNet assembly instead of legacy YAML support in Cuemon.Core assembly | ||||||
|
|
||||||
| ## [8.0.0] - 2023-11-14 | ||||||
|
|
||||||
| ### Added | ||||||
|
|
||||||
| - Tool for extracting NLS surrogates `tooling/gse` (Globalization Surrogates Extractor); this was done to mitigate the original design decision that was most [unfortunate](https://github.com/gimlichael/Cuemon/commit/71ff4f9ecb95897170aab1e6ba894c320ae095bd) | ||||||
|
|
||||||
| ### Fixed | ||||||
|
|
||||||
| - National Language Support (NLS) surrogates was updated in the Codebelt.Extensions.Globalization assembly | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix grammatical error in NLS surrogates update. There's a subject-verb agreement issue in the sentence about NLS surrogates. Please apply the following change: - National Language Support (NLS) surrogates was updated in the Codebelt.Extensions.Globalization assembly
+ National Language Support (NLS) surrogates were updated in the Codebelt.Extensions.Globalization assembly📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool
|
||||||
|
|
||||||
| ## [7.0.0] 2022-11-09 | ||||||
|
|
||||||
| ### Added | ||||||
|
|
||||||
| - CultureInfoExtensions class in the Codebelt.Extensions.Globalization namespace that consist of extension methods for the CultureInfo class: UseNationalLanguageSupport | ||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider adding error handling and logging to the script.
While the script covers all necessary steps for building and tagging the Docker image, it could benefit from some additional robustness:
Here's an example of how you could enhance the script:
This enhanced version includes error checking, logging, and a try-catch block to handle any unexpected errors.