Skip to content

V9.0.3/package maintenance #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gimlichael merged 6 commits into from
May 25, 2025
Merged

V9.0.3/package maintenance #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1979e13
:package: updated NuGet package definition
gimlichael May 25, 2025
4cfcc7e
:arrow_up: bump dependencies
gimlichael May 25, 2025
2d75005
:construction_worker: transitioned to reusable workflows
gimlichael May 25, 2025
803d47d
:speech_balloon: updated community health pages
gimlichael May 25, 2025
1cd6f3a
fix
gimlichael May 25, 2025
3f0793c
fix
gimlichael May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .docfx/Dockerfile.docfx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
FROM nginx:1.27.3-alpine AS base
FROM --platform=$BUILDPLATFORM nginx:1.27.5-alpine AS base
RUN rm -rf /usr/share/nginx/html/*

Comment on lines +1 to 3
Copy link

@coderabbitai coderabbitai bot May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Unused cleanup stage – refactor or remove
The base stage cleans /usr/share/nginx/html but is never used in the final image. To ensure the cleanup step applies, either remove the base stage entirely or derive the final stage from it.

Example change:

-FROM nginx:1.27.5-alpine AS final
+FROM base AS final

This preserves the cleanup before copying the built content.

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In .docfx/Dockerfile.docfx at lines 1 to 3, the base stage removes files from
/usr/share/nginx/html but is not used in the final image, making the cleanup
ineffective. To fix this, either remove the base stage if unused or modify the
final stage to inherit from the base stage so that the cleanup step applies
before adding the built content.

FROM codebeltnet/docfx:2.77.0 AS build
FROM --platform=$BUILDPLATFORM codebeltnet/docfx:2.78.3 AS build

ADD [".", "docfx"]

RUN cd docfx; \
docfx build

FROM base AS final
FROM nginx:1.27.5-alpine AS final
WORKDIR /usr/share/nginx/html
COPY --from=build /build/docfx/wwwroot /usr/share/nginx/html
Comment on lines +11 to 13
Copy link

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider reusing the previously built base (using 'FROM base AS final') instead of re-fetching the nginx image to ensure consistency in the platform specification across stages.

Suggested change
FROM nginx:1.27.5-alpine AS final
WORKDIR /usr/share/nginx/html
COPY --from=build /build/docfx/wwwroot /usr/share/nginx/html
FROM base AS final
WORKDIR /usr/share/nginx/html
COPY --from=build /build/docfx/wwwroot /usr/share/nginx/html

Copilot uses AI. Check for mistakes.

Expand Down
102 changes: 26 additions & 76 deletions .github/workflows/pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,95 +20,45 @@ on:

jobs:
build:
name: 🛠️ Build
runs-on: ubuntu-22.04
timeout-minutes: 15
name: call-build
strategy:
matrix:
configuration: [Debug, Release]
framework: [net9.0,net8.0,netstandard2.0]
outputs:
version: ${{ steps.minver-calculate.outputs.version }}
steps:
- name: Checkout
uses: codebeltnet/git-checkout@v1

- name: Install .NET
uses: codebeltnet/install-dotnet@v1
with:
includePreview: true

- name: Install MinVer
uses: codebeltnet/dotnet-tool-install-minver@v1

- id: minver-calculate
name: Calculate Version
uses: codebeltnet/minver-calculate@v2

- name: Download globalization.snk file
uses: codebeltnet/gcp-download-file@v1
with:
serviceAccountKey: ${{ secrets.GCP_TOKEN }}
bucketName: ${{ secrets.GCP_BUCKETNAME }}
objectName: globalization.snk

- name: Restore Dependencies
uses: codebeltnet/dotnet-restore@v2

- name: Build for ${{ matrix.framework }} (${{ matrix.configuration }})
uses: codebeltnet/dotnet-build@v2
with:
configuration: ${{ matrix.configuration }}
framework: ${{ matrix.framework }}
uses: codebeltnet/jobs-dotnet-build/.github/workflows/default.yml@v1
with:
projects: src/**/*.csproj
configuration: ${{ matrix.configuration }}
strong-name-key-filename: globalization.snk
secrets:
GCP_TOKEN: ${{ secrets.GCP_TOKEN }}
GCP_BUCKETNAME: ${{ secrets.GCP_BUCKETNAME }}

pack:
name: 📦 Pack
runs-on: ubuntu-22.04
timeout-minutes: 15
name: call-pack
needs: [build]
strategy:
matrix:
configuration: [Debug, Release]
needs: [build]
steps:
- name: Install .NET
uses: codebeltnet/install-dotnet@v1
with:
includePreview: true

- name: Pack for ${{ matrix.configuration }}
uses: codebeltnet/dotnet-pack@v2
with:
configuration: ${{ matrix.configuration }}
uploadPackedArtifact: true
version: ${{ needs.build.outputs.version }}
uses: codebeltnet/jobs-dotnet-pack/.github/workflows/default.yml@v1
with:
configuration: ${{ matrix.configuration }}
upload-packed-artifact: true
version: ${{ needs.build.outputs.version }}

test:
name: 🧪 Test
name: call-test
needs: [build]
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, windows-2022]
os: [ubuntu-24.04, windows-2022]
configuration: [Debug, Release]
runs-on: ${{ matrix.os }}
timeout-minutes: 15
steps:
- name: Checkout
uses: codebeltnet/git-checkout@v1

- name: Install .NET
uses: codebeltnet/install-dotnet@v1
with:
includePreview: true

- name: Install .NET Tool - Report Generator
uses: codebeltnet/dotnet-tool-install-reportgenerator@v1

- name: Test with ${{ matrix.configuration }} build
uses: codebeltnet/dotnet-test@v3
with:
configuration: ${{ matrix.configuration }}
buildSwitches: -p:SkipSignAssembly=true
uses: codebeltnet/jobs-dotnet-test/.github/workflows/default.yml@v1
with:
projects: test/**/*.csproj
configuration: ${{ matrix.configuration }}
runs-on: ${{ matrix.os }}
build-switches: -p:SkipSignAssembly=true

sonarcloud:
name: call-sonarcloud
Expand Down Expand Up @@ -136,8 +86,8 @@ jobs:
deploy:
if: github.event_name != 'pull_request'
name: call-nuget
needs: [build,pack,test,sonarcloud,codecov,codeql]
uses: codebeltnet/jobs-nuget/.github/workflows/default.yml@v1
needs: [build, pack, test, sonarcloud, codecov, codeql]
uses: codebeltnet/jobs-nuget-push/.github/workflows/default.yml@v1
with:
version: ${{ needs.build.outputs.version }}
environment: Production
Expand Down
8 changes: 7 additions & 1 deletion .nuget/Codebelt.Extensions.Globalization/PackageReleaseNotes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
Version 9.0.2
Version 9.0.3
Availability: .NET 9, .NET 8 and .NET Standard 2.0

# ALM
- CHANGED Dependencies have been upgraded to the latest compatible versions for all supported target frameworks (TFMs)

Version 9.0.2
Copy link

Copilot AI May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a duplicate version entry (Version 9.0.2) following the update to Version 9.0.3. Please verify whether the older release note should be removed to avoid confusion.

Copilot uses AI. Check for mistakes.
Availability: .NET 9, .NET 8 and .NET Standard 2.0

# ALM
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ For more details, please refer to `PackageReleaseNotes.txt` on a per assembly ba
> [!NOTE]
> Changelog entries prior to version 9.0.1 was migrated from previous versions of Cuemon.Extensions.Globalization.

## [9.0.3] - 2025-05-25

This is a service update that focuses on package dependencies.

## [9.0.2] - 2025-04-16

This is a service update that focuses on package dependencies.
Expand Down
8 changes: 4 additions & 4 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Codebelt.Extensions.Xunit" Version="10.0.0" />
<PackageVersion Include="Codebelt.Extensions.YamlDotNet" Version="9.0.2" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
<PackageVersion Include="Codebelt.Extensions.Xunit" Version="10.0.1" />
<PackageVersion Include="Codebelt.Extensions.YamlDotNet" Version="9.0.3" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
<PackageVersion Include="MinVer" Version="6.0.0" />
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
<PackageVersion Include="coverlet.msbuild" Version="6.0.4" />
<PackageVersion Include="xunit" Version="2.9.3" />
<PackageVersion Include="xunit.runner.console" Version="2.9.3" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.0.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.0" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion testenvironments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
{
"name": "Docker-Ubuntu",
"type": "docker",
"dockerImage": "gimlichael/ubuntu-testrunner:mono-net8.0.408-9.0.203"
"dockerImage": "gimlichael/ubuntu-testrunner:mono-net8.0.409-9.0.300"
}
]
}
Loading