V9.0.5/service update #9
Conversation
WalkthroughThis update introduces a build argument for the nginx version in the Dockerfile, updates reusable workflow versions in the CI/CD pipeline, documents a new package release, updates a package dependency version, and refreshes a test environment Docker image tag. All changes are configuration or documentation updates without code-level modifications. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This service update (v9.0.5) bumps dependency versions, updates CI workflows, parameterizes the DocFX Docker setup, and refreshes the test environment image.
- Bumped
Codebelt.Extensions.Xunitand global package versions. - Switched GitHub Actions sonarcloud/codeql jobs to v2 and added
ARGfor NGINX version in Dockerfile. - Updated Docker test runner image and added a v9.0.5 entry to changelog and release notes.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| testenvironments.json | Updated dockerImage tag to net8.0.412-9.0.302 |
| Directory.Packages.props | Bumped Codebelt.Extensions.Xunit from 10.0.3 to 10.0.4 |
| CHANGELOG.md | Added ## [9.0.5] - 2025-07-11 entry |
| .nuget/Codebelt.Extensions.Globalization/PackageReleaseNotes.txt | Updated to Version 9.0.5 with upgraded dependency notes |
| .github/workflows/pipelines.yml | Changed sonarcloud/codeql workflow references from @v1 to @v2 |
| .docfx/Dockerfile.docfx | Introduced ARG NGINX_VERSION=1.29.0-alpine and replaced hardcoded versions |
| @@ -1,4 +1,6 @@ | |||
| FROM --platform=$BUILDPLATFORM nginx:1.28.0-alpine AS base | |||
| ARG NGINX_VERSION=1.29.0-alpine | |||
There was a problem hiding this comment.
[nitpick] Consider moving the ARG NGINX_VERSION declaration before the first FROM to keep all build arguments centralized and ensure consistency if additional stages are added.
| "name": "Docker-Ubuntu", | ||
| "type": "docker", | ||
| "dockerImage": "gimlichael/ubuntu-testrunner:net8.0.411-9.0.301" | ||
| "dockerImage": "gimlichael/ubuntu-testrunner:net8.0.412-9.0.302" |
There was a problem hiding this comment.
For improved reproducibility and security, consider pinning the Docker image to a specific digest instead of a mutable tag.
| "dockerImage": "gimlichael/ubuntu-testrunner:net8.0.412-9.0.302" | |
| "dockerImage": "gimlichael/ubuntu-testrunner@sha256:<digest>" |
| Version 9.0.5 | ||
| Availability: .NET 9, .NET 8 and .NET Standard 2.0 |
There was a problem hiding this comment.
[nitpick] Remove the leading BOM or hidden character before Version 9.0.5 to avoid encoding issues and ensure consistent formatting across environments.
| Version 9.0.5 | |
| Availability: .NET 9, .NET 8 and .NET Standard 2.0 | |
| Version 9.0.5 | |
| Availability: .NET 9, .NET 8 and .NET Standard 2.0 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
CHANGELOG.md (1)
10-13: Consider adding concrete details to the changelog entry.The new 9.0.5 entry repeats the generic “service update” wording used in previous versions. Calling out which dependencies were upgraded (e.g., Xunit 10.0.4, NGINX 1.29.0-alpine) provides more value to readers.
.nuget/Codebelt.Extensions.Globalization/PackageReleaseNotes.txt (1)
1-5: Release notes entry looks correct – watch out for BOM + leading space artifacts.The file now starts with a UTF-8 BOM and a zero-width space before “Version”. Some tooling renders these characters; if that becomes an issue, consider stripping them.
.docfx/Dockerfile.docfx (1)
13-13: RepeatARG NGINX_VERSIONafter the lastFROMfor maximum compatibility.Some older Docker versions require re-declaring build args after each stage transition. Harmless on newer engines and prevents “unknown variable” issues.
FROM nginx:${NGINX_VERSION} AS final +ARG NGINX_VERSION.github/workflows/pipelines.yml (1)
82-82: Ensurejobs-codeql@v2remains compatible & consider aligning CodecovSame concern as above—pipeline will fail if
@v2is missing or its required inputs changed.
Additionally, thecodecovjob still references@v1; consider bumping it for consistency once you confirm a stable v2 exists.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.docfx/Dockerfile.docfx(2 hunks).github/workflows/pipelines.yml(2 hunks).nuget/Codebelt.Extensions.Globalization/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(1 hunks)testenvironments.json(1 hunks)
🔇 Additional comments (4)
Directory.Packages.props (1)
6-6: Version bump looks fine – make sure consuming projects restore the new package.
Codebelt.Extensions.Xunit10.0.4 is a patch update, so no breaking changes are expected, but double-check that CI still passes for all target frameworks after the restore.testenvironments.json (1)
12-12: Verify that the new test-runner image is available and pulls successfully.Before merging, confirm that
gimlichael/ubuntu-testrunner:net8.0.412-9.0.302exists in the registry and that CI can pull it; otherwise pipeline jobs will fail..docfx/Dockerfile.docfx (1)
1-3: Good move parameterising the NGINX version.Centralising the version with
ARG NGINX_VERSIONsimplifies future upgrades and reduces duplication..github/workflows/pipelines.yml (1)
64-69: ✅jobs-sonarcloud@v2tag and inputs verified.
v2tag exists in codebeltnet/jobs-sonarcloud- Required inputs (
organization,projectKey,version) match exactly- Optional inputs (
host,include-preview,parameters,timeout-minutes) have sensible defaultssecrets: inheritwill pass throughSONAR_TOKENas expectedNo changes needed.
|
This pull request includes updates to dependencies, workflow configurations, and Dockerfile setups across multiple files. The changes aim to enhance compatibility, streamline workflows, and ensure the use of the latest versions of dependencies and tools.
Dependency Updates:
.nuget/Codebelt.Extensions.Globalization/PackageReleaseNotes.txt: Updated to version9.0.5, highlighting upgraded dependencies for all supported target frameworks.Directory.Packages.props: Incremented the version ofCodebelt.Extensions.Xunitfrom10.0.3to10.0.4.Workflow Configuration Updates:
.github/workflows/pipelines.yml: Updatedsonarcloudandcodeqljob configurations to use versionv2of their respective workflows. [1] [2]Dockerfile Enhancements:
.docfx/Dockerfile.docfx: Parameterized the NGINX version using anARGdirective and updated the base and final stages to use the new version (1.29.0-alpine). [1] [2]Test Environment Update:
testenvironments.json: Updated the Docker image for theDocker-Ubuntutest environment togimlichael/ubuntu-testrunner:net8.0.412-9.0.302.Changelog Update:
CHANGELOG.md: Added an entry for version9.0.5, describing it as a service update focused on package dependencies.Summary by CodeRabbit