Skip to content

adds unique flag check functionality #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m0hanraj merged 1 commit into from
Mar 26, 2023
Merged

adds unique flag check functionality #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions src/components/LineItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { Flag } from '../../types';
import DeleteModal from './DeleteModal';
import SdkModal from './SdkModal';
import { __ } from '@wordpress/i18n';
import { checkIfFlagExists } from '../utils';

interface LineItemProps {
flags: Flag[];
Expand All @@ -31,6 +32,8 @@ const LineItem = ({

const [hasError, setHasError] = useState(false);

const [flagExist, setFlagExist] = useState(false);

const inputRef = useRef<HTMLInputElement>(null);

useEffect(() => {
Expand All @@ -45,28 +48,34 @@ const LineItem = ({
closeModal();
};

const handleFlagToggle = (flagId: number, flagEnv = 'prod') => {
const handleFlagToggle = (flagId: number) => {
const updatedFlags = flags.map((flag: Flag) => {
if (flag.id === flagId) {
if (flagEnv === 'prod') {
flag.enabled = !flag.enabled;
} else {
flag.preProdEnabled = !flag.preProdEnabled;
}
flag.enabled = !flag.enabled;
}
return flag;
});
setFlags(updatedFlags);
};

const handleFlagEdit = (value: string, flagId: number) => {
//Flag alphanumeric validation
if (value.match(/^[a-zA-Z0-9\_-]*$/)) {
setHasError(false);
setDisableSave(false);
} else {
setHasError(true);
setDisableSave(true);
}

//Existing flag check
if (checkIfFlagExists(flags, value)) {
setFlagExist(true);
setDisableSave(true);
} else {
setFlagExist(false);
setDisableSave(false);
}
const updatedFlags = flags.map((flag: Flag) => {
if (flag.id === flagId) {
flag.name = value;
Expand Down Expand Up @@ -142,7 +151,17 @@ const LineItem = ({
/>
</FlexItem>
</Flex>
{hasError && (
{flagExist && (
<BaseControl
className="flag-name-error"
help={__('Flag name already exists.')}
id={`${item.id}`}
>
{}
</BaseControl>
)}

{hasError && !flagExist && (
<>
<BaseControl
className="flag-name-error"
Expand Down
4 changes: 4 additions & 0 deletions src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,7 @@ export const updateFlags = async (

return result;
};

export const checkIfFlagExists = (flags: Flag[], flagName: string): boolean => {
return flags.filter((flag) => flag.name === flagName).length > 0;
};