Add new unit tests and refactor async expectations#88
Merged
Conversation
Added unit tests for Snippet, Clipboard, checkIfFlagExists function, and SdkModal components. Additionally, refactored end-to-end tests in feature-flags.spec.ts to correctly await asynchronous expectations to improve reliability and readability of tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=============================================
- Coverage 96.29% 81.67% -14.63%
Complexity 24 24
=============================================
Files 4 17 +13
Lines 81 191 +110
Branches 0 9 +9
=============================================
+ Hits 78 156 +78
- Misses 3 27 +24
- Partials 0 8 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Several packages were updated in yarn.lock file, including "@ampproject/remapping" and "@babel". These updates can include bug fixes, performance improvements, and security updates provided by the package maintainers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests for Snippet, Clipboard, checkIfFlagExists function, and SdkModal components. Additionally, refactored end-to-end tests in feature-flags.spec.ts to correctly await asynchronous expectations to improve reliability and readability of tests.