Skip to content

Fix/wdio cannot start with cloud #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavertMik merged 13 commits into from
Jan 10, 2019
Merged

Fix/wdio cannot start with cloud #1424

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d1b0f33
Merge pull request #1 from Codeception/master
kobenguyent Nov 1, 2018
cec558e
Merge pull request #2 from Codeception/master
kobenguyent Nov 12, 2018
a23caad
Merge pull request #3 from Codeception/master
kobenguyent Nov 21, 2018
a0dec9a
Merge pull request #4 from Codeception/master
kobenguyent Nov 26, 2018
e146dbd
Merge pull request #5 from Codeception/master
kobenguyent Dec 7, 2018
8461caf
Merge pull request #6 from Codeception/master
kobenguyent Dec 14, 2018
03f7988
Merge pull request #7 from Codeception/master
kobenguyent Dec 15, 2018
af0307f
Merge pull request #8 from Codeception/master
kobenguyent Dec 21, 2018
e32ebbd
Merge pull request #9 from Codeception/master
kobenguyent Dec 26, 2018
72f58c8
Merge pull request #10 from Codeception/master
kobenguyent Dec 28, 2018
8e2051b
Merge pull request #11 from Codeception/master
kobenguyent Dec 29, 2018
e960ea5
fix issue that cloud service cannot start
Jan 8, 2019
047268b
updated based on feedback
Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/helper/WebDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,11 @@ class WebDriver extends Helper {
_validateConfig(config) {
const defaults = {
// webdriverio defaults
protocol: 'http',
host: '0.0.0.0',
port: 4444,
path: '/wd/hub',
// Those will prevent cloud service to be initialized
// protocol: 'http',
// host: '0.0.0.0',
// port: 4444,
// path: '/wd/hub',
logLevel: 'error',

// codeceptjs
Expand Down