Skip to content

Webdriver: grabHTMLFrom returns array of innerHTML from the set of matched elements #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavertMik merged 1 commit into from
Feb 4, 2019
Merged

Webdriver: grabHTMLFrom returns array of innerHTML from the set of matched elements #1481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/helper/WebDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,10 +777,9 @@ class WebDriver extends Helper {
* * *Appium*: supported only for web testing
*/
async grabHTMLFrom(locator) {
const res = await this._locate(locator, true);
assertElementExists(res, locator);
const elem = usingFirstElement(res);
const html = await elem.getHTML();
const elems = await this._locate(locator, true);
assertElementExists(elems, locator);
const html = Promise.all(elems.map(async elem => elem.getHTML(false)));
this.debugSection('Grab', html);
return html;
}
Expand Down
8 changes: 4 additions & 4 deletions test/helper/WebDriver_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,13 @@ describe('WebDriver', function () {
.then(() => wd.grabSource())
.then(source => assert.notEqual(source.indexOf('<title>TestEd Beta 2.0</title>'), -1, 'Source html should be retrieved')));

it('should grab the source for element', () => wd.amOnPage('/')
it('should grab the innerHTML for an element', () => wd.amOnPage('/')
.then(() => wd.grabHTMLFrom('#area1'))
.then(source => assert.equal(
.then(source => assert.deepEqual(
source,
`<div id="area1" qa-id="test">
[`
<a href="/form/file" qa-id="test" qa-link="test"> Test Link </a>
</div>`,
`],
)));
});

Expand Down