feat: move to Locator playwright

[kobenguyent]

Motivation/Description of the PR

• Resolves [FEATURE REQUEST](playwright) migrate locators from ElementHandle to Locator.  #3677

Applicable helpers:

• Playwright

Type of change

• 🐛 Bug fix

Checklist:

• Lint checking (Run npm run lint)
• Local tests are passed (Run npm test)

[DavertMik]

Good to me
But can we use new clear method?

[DavertMik]

@kobenguyent @EgorBodnar

Published this PR as codeceptjs@3.5.4-beta.1
Please check this new version

[kobenguyent]

@kobenguyent @EgorBodnar

Published this PR as codeceptjs@3.5.4-beta.1

Please check this new version

Thank you @DavertMik 😊

[ngraf]

I ran my biggest test suite with a lot of different locators and techniques against 3.5.4-beta.1 with Playwright.
I discovered one issue:

🐞 Issue: I.switchTo(locator) step does not fail when locator was not found.
Expected
switchTo does fail when locator does not match any element.
Actual
switchTo does not fail when locator does not match any element.

Proof:
This scenario fails as expected with latest stable version, but is unexpectedly green in tested beta version:

Scenario('Playwright locator Bug with iframe not found', async ({I}) => {
    I.amOnPage('https://www.w3schools.com/html/html_iframe.asp')
    // I.switchTo('iframe[ title = "W3Schools HTML Tutorial']) // This would be the correct locator
    I.switchTo('iframe[ title = "W3Schools HTML Tutorial    -> I ADDED THIS TEXT WITH THE GOAL TO NOT FIND IFRAME. TEST SHOULD FAIL BUT IT DOES NOT WITH CodeceptJS version 3.5.4-beta.1 <-"]')

})

[kobenguyent]

I.amOnPage('https://www.w3schools.com/html/html_iframe.asp')
// I.switchTo('iframe[ title = "W3Schools HTML Tutorial']) // This would be the correct locator
I.switchTo('iframe[ title = "W3Schools HTML Tutorial -> I ADDED THIS TEXT WITH THE GOAL TO NOT FIND IFRAME. TEST SHOULD FAIL BUT IT DOES NOT WITH CodeceptJS version 3.5.4-beta.1 <-"]')

Hi @ngraf I tried your scenario against 3.x and nothing fails, so I think it's not the issue from this Locator changes.

    it.only('should switch reference to iframe content', () => {
      I.amOnPage('https://www.w3schools.com/html/html_iframe.asp');
      // I.switchTo('iframe[ title = "W3Schools HTML Tutorial']) // This would be the correct locator
      I.switchTo('iframe[ title = "W3Schools HTML Tutorial    -> I ADDED THIS TEXT WITH THE GOAL TO NOT FIND IFRAME. TEST SHOULD FAIL BUT IT DOES NOT WITH CodeceptJS version 3.5.4-beta.1 <-"]')

    });

➜  CodeceptJS git:(3.x) ✗ npm run test:unit:webbapi:playwright

> codeceptjs@3.5.3 test:unit:webbapi:playwright
> mocha test/helper/Playwright_test.js



  Playwright
    #switchTo
      ✔ should switch reference to iframe content


  1 passing (825ms)

➜  CodeceptJS git:(3.x) ✗ 

[ngraf]

Ok, I guess you are right and the issue is not caused by this feature branch then.