Expand saveScreenshot() functionality #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 15, 2017 13:23
This was causing the SeleniumWebdriver tests to fail as the window size isn't reset after prior tests.
Contributor
|
Wow, thanks for updating all helpers and tests! |
Contributor
Author
|
No worries, happy to help 😁 |
|
Somehow, this still doesn't take full page screenshot for me :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #522.
Changes (all helpers):
saveScreenshot()- Takes a second argument oftrueto capture full page._failed- Updated behaviour to take advantage of new functionality, failed tests now capture the full page.