-
-
Notifications
You must be signed in to change notification settings - Fork 752
placeholder for ~ locator only test case write once run on both Appium and WebDriverIO #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…m and WebDriverIO
lib/helper/WebDriverIO.js
Outdated
| * placeholder for ~ locator only test case write once run on both Appium and WebDriverIO | ||
| */ | ||
| runOnAndroid(caps, fn) { | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary return statement no-useless-return
lib/helper/WebDriverIO.js
Outdated
| * placeholder for ~ locator only test case write once run on both Appium and WebDriverIO | ||
| */ | ||
| runOnIOS(caps, fn) { | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary return statement no-useless-return
|
Thanks for PR. I'd ask you to wait for about an hour and resend it. I'm heavily reworking WebDriverIO and Appium helpers right now. I have some questions:
|
Is that possible? As you can see in my codecept.conf.js , Appium use
No, |
|
|
If my test case is just run on Mobile native and PC browser, OK, and I tried successfully, just change from to But if test case alse want to run on Mobile browser and Mobile native and PC browser, that's so complicated and I don't have the aspiration to edit the helpers: {} again... So I think that the three APIs only in Appium also support in WebDriverIO is elegant, and other APIs only in Appium can just be wraped by the three APIs to be used in WebDriverIO. |
|
Ok, thanks! |
Test case with locator ~ now can write once run on Android, iOS and Web with #728 , but if write I.runOnIOS() I.runOnAndroid() or I.runInWeb() in test case, then we also need a reactweb_helper.js required in codecept.conf.js , if this PR is accepted and publish a new version, then the reactweb_helper.js is not needed.