Skip to content

Conversation

@andiamantoukos-fadv
Copy link

Fixes

  • Removed gulp execution from docker-compose for unit tests since it is no longer part of package.json.
  • Fixed a bug where a waiter would report waiting for "null" seconds if waiting for an amount of time specified in helper options and thus not passing a time to waitForText invocation.
  • Updated a failing test to pass by adding in quotation marks for object print.

Improvements

  • Updated missing JSdoc notation around parameter types.
  • Touched up some Markdown to be in line with existing documentation style.
  • Put _beforeStep and _afterStep back in with associated acceptance test.
  • Put async/await in functions missing it in puppeteer helper.
  • Added build npm script to run TypeScript compiler.

@codeceptjs codeceptjs deleted a comment Jan 8, 2018
@DavertMik
Copy link
Contributor

Thank you very much for fixes and improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants