Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 90.23% 89.82% -0.41%
==========================================
Files 389 324 -65
Lines 11792 9383 -2409
Branches 2063 1676 -387
==========================================
- Hits 10640 8428 -2212
+ Misses 1052 891 -161
+ Partials 100 64 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michelletran-sentry
left a comment
There was a problem hiding this comment.
I'm OK with this, but would prefer to remove this altogether if it's not being used.
This pretty much copied over the oauth-related code from `Bitbucket` to `BitbucketServer`, and gets rid of the `oauth2` and `tlslite-ng` dependencies.
7ba80d8 to
7f6ddd9
Compare
I will merge as-is then, following up on conversations to completely remove this. Summary so far is that this is indeed not enabled in SaaS, so self-hosted might be the only ones impacted by this, and it seems like BitbucketServer itself is already EOL. |
This pretty much copied over the oauth-related code from
BitbuckettoBitbucketServer, and gets rid of theoauth2andtlslite-ngdependencies.This does a few simplifications compared to the
Bitbucketcode, namely not caring about non-jsonbodys, as I believe the existing code will only ever pass JSON payloads.fixes part of https://github.com/codecov/internal-issues/issues/436
prerequisite for #423