Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Migrate BitbucketServer to oauthlib#426

Merged
Swatinem merged 3 commits intomainfrom
swatinem/bitbucket-oauth
Nov 14, 2024
Merged

Migrate BitbucketServer to oauthlib#426
Swatinem merged 3 commits intomainfrom
swatinem/bitbucket-oauth

Conversation

@Swatinem
Copy link
Contributor

This pretty much copied over the oauth-related code from Bitbucket to BitbucketServer, and gets rid of the oauth2 and tlslite-ng dependencies.

This does a few simplifications compared to the Bitbucket code, namely not caring about non-json bodys, as I believe the existing code will only ever pass JSON payloads.


fixes part of https://github.com/codecov/internal-issues/issues/436
prerequisite for #423

@Swatinem Swatinem requested review from a team and michelletran-sentry November 14, 2024 11:46
@Swatinem Swatinem self-assigned this Nov 14, 2024
@Swatinem Swatinem requested a review from nora-shap November 14, 2024 11:48
@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (bb18502) to head (7f6ddd9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   90.23%   89.82%   -0.41%     
==========================================
  Files         389      324      -65     
  Lines       11792     9383    -2409     
  Branches     2063     1676     -387     
==========================================
- Hits        10640     8428    -2212     
+ Misses       1052      891     -161     
+ Partials      100       64      -36     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michelletran-sentry michelletran-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this, but would prefer to remove this altogether if it's not being used.

This pretty much copied over the oauth-related code from `Bitbucket` to `BitbucketServer`, and gets rid of the `oauth2` and `tlslite-ng` dependencies.
@Swatinem
Copy link
Contributor Author

I'm OK with this, but would prefer to remove this altogether if it's not being used.

I will merge as-is then, following up on conversations to completely remove this.

Summary so far is that this is indeed not enabled in SaaS, so self-hosted might be the only ones impacted by this, and it seems like BitbucketServer itself is already EOL.

@Swatinem Swatinem added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 8d91acc Nov 14, 2024
@Swatinem Swatinem deleted the swatinem/bitbucket-oauth branch November 14, 2024 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants