Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Apr 2, 2025

Both api and worker currently have their own modules exporting a cache instance, which at least in API is being misused in some places.

By exposed an ready to use instance directly from shared, it should be harder to misuse.

@Swatinem Swatinem requested a review from a team April 2, 2025 10:03
@Swatinem Swatinem self-assigned this Apr 2, 2025
Both `api` and `worker` currently have their own modules exporting a `cache` instance, which at least in API is being misused in some places.

By exposed an ready to use instance directly from `shared`, it should be harder to misuse.
@Swatinem Swatinem force-pushed the swatinem/cache-instance branch from 4702696 to 17d61c4 Compare April 2, 2025 10:23
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Performance Report

Merging #597 will not alter performance

Comparing swatinem/cache-instance (4a7e28b) with main (d591317)

Summary

✅ 9 untouched benchmarks

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (d591317) to head (4a7e28b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   88.64%   88.64%   -0.01%     
==========================================
  Files         464      464              
  Lines       12844    12839       -5     
  Branches     1464     1464              
==========================================
- Hits        11386    11381       -5     
  Misses       1153     1153              
  Partials      305      305              
Flag Coverage Δ
shared-docker-uploader 88.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit ece4366 Apr 2, 2025
12 checks passed
@Swatinem Swatinem deleted the swatinem/cache-instance branch April 2, 2025 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants