Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

@Swatinem
Copy link
Contributor

We would like to cache bytes, which is being rejected by JSON.
msgpack does not have that problem, and should be slightly faster/smaller than JSON in either case.

@Swatinem Swatinem requested a review from matt-codecov April 10, 2025 12:50
@Swatinem Swatinem self-assigned this Apr 10, 2025
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (ae1d4cf) to head (a11b128).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   88.59%   88.60%           
=======================================
  Files         463      463           
  Lines       12786    12776   -10     
  Branches     1458     1454    -4     
=======================================
- Hits        11328    11320    -8     
+ Misses       1153     1151    -2     
  Partials      305      305           
Flag Coverage Δ
shared-docker-uploader 88.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 10, 2025

CodSpeed Performance Report

Merging #601 will not alter performance

Comparing swatinem/msgpack-cache (a11b128) with main (ae1d4cf)

Summary

✅ 9 untouched benchmarks

@Swatinem Swatinem requested a review from a team April 10, 2025 15:05
@Swatinem Swatinem added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit a235055 Apr 11, 2025
12 checks passed
@Swatinem Swatinem deleted the swatinem/msgpack-cache branch April 11, 2025 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants