Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Try using uv for worker#896

Closed
Swatinem wants to merge 4 commits intomainfrom
swatinem/try-migrate-uv
Closed

Try using uv for worker#896
Swatinem wants to merge 4 commits intomainfrom
swatinem/try-migrate-uv

Conversation

@Swatinem
Copy link
Contributor

I tried taking inspiration from https://hynek.me/articles/docker-uv/, but hit some snags along the way.

I would need to dig a bit deeper learning how the docker setup fully functions.

@Swatinem Swatinem self-assigned this Nov 15, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (-0.07%) ⬇️
OutsideTasks 95.95% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (c20baed) to head (707d492).
Report is 269 commits behind head on main.

Current head 707d492 differs from pull request most recent head 94535f7

Please upload reports for the commit 94535f7 to get more accurate results.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (-0.07%) ⬇️
OutsideTasks 95.95% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (c20baed) to head (707d492).
Report is 269 commits behind head on main.

Current head 707d492 differs from pull request most recent head 94535f7

Please upload reports for the commit 94535f7 to get more accurate results.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (-0.07%) ⬇️
OutsideTasks 95.95% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@codecov-public-qa
Copy link

codecov-public-qa bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (c20baed) to head (707d492).
Report is 269 commits behind head on main.

Current head 707d492 differs from pull request most recent head 94535f7

Please upload reports for the commit 94535f7 to get more accurate results.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   98.04%   98.01%   -0.04%     
==========================================
  Files         444      444              
  Lines       35435    35543     +108     
==========================================
+ Hits        34744    34838      +94     
- Misses        691      705      +14     
Flag Coverage Δ
integration 41.99% <0.00%> (+0.03%) ⬆️
unit 90.87% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.90% <100.00%> (-0.02%) ⬇️
OutsideTasks 92.75% <100.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
database/engine.py 91.48% <100.00%> (ø)
database/tests/unit/test_engine.py 100.00% <ø> (ø)
tasks/delete_owner.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@github-actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Instead of using `uv` virtualenv to build the image, we want to build the wheels
so that the docker app won't need to have dependency on build tools.
There's a few things that were fixed for the SQLAlchemy upgrade.
@Swatinem Swatinem closed this Apr 10, 2025
@Swatinem Swatinem deleted the swatinem/try-migrate-uv branch April 10, 2025 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants