Skip to content

Conversation

@ikrevem
Copy link
Contributor

@ikrevem ikrevem commented Dec 4, 2023

This pull request fixes some issues found in the two code examples in the README.

The main changes are:

  • Replace exact and like with exact_schema and like_schema (otherwise an ImportError occurs)
  • Initialize the Enum object (which is used to validate the user role) by directly passing the three values as arguments (instead of passing a list which causes a SchemaError)
  • Add the description key to the valid examples in test_users_endpoint (otherwise the validation fails with a SchemaError reporting a missing key)

@ikrevem ikrevem requested a review from codedawi as a code owner December 4, 2023 11:57
@ikrevem ikrevem changed the title Fix code examples in README Fixes code examples in README Dec 4, 2023
Copy link
Owner

@codedawi codedawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@codedawi codedawi merged commit ad98484 into codedawi:master Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants