Implement support for unwrapUnaryRecords option#12
Closed
cfraz89 wants to merge 1 commit intocodedownio:masterfrom
Closed
Implement support for unwrapUnaryRecords option#12cfraz89 wants to merge 1 commit intocodedownio:masterfrom
cfraz89 wants to merge 1 commit intocodedownio:masterfrom
Conversation
Contributor
|
Sorry for the long delay @cfraz89 -- I'll try to get this merged soon! |
|
We recently found ourselves wanting this on a project at work. Is there still interest in this PR if we were to resolve conflicts and get CI passing? |
Contributor
|
Definitely! Sorry again for not getting this merged sooner. I actually had a WIP branch open where I added more tests to exercise the new functionality. There are some test failures at the moment that I haven't looked at yet. I just pushed the branch here: https://github.com/codedownio/aeson-typescript/tree/francesco-rebased If someone could get the tests passing I'd be happy to merge it. |
Contributor
|
This is implemented now in 7e4c7b1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect the unwrapUnaryRecords option. When True, this exports unary records / newtypes as a type alias to the type of the single field within.