Skip to content

Allow th-abstraction 0.3#6

Merged
thomasjm merged 2 commits intocodedownio:masterfrom
braunse:master
Jun 10, 2019
Merged

Allow th-abstraction 0.3#6
thomasjm merged 2 commits intocodedownio:masterfrom
braunse:master

Conversation

@braunse
Copy link
Copy Markdown

@braunse braunse commented Jun 9, 2019

th-abstraction 0.3 renamed the datatypeVars field to datatypeInstTypes. This pull request enables usage of the renamed field, guarded by CPP.

@thomasjm
Copy link
Copy Markdown
Contributor

thomasjm commented Jun 9, 2019

Awesome, thanks for fixing that -- could you add an entry to .travis.yml for an applicable resolver (perhaps nightly-2019-06-09) so this gets tested?

@braunse
Copy link
Copy Markdown
Author

braunse commented Jun 9, 2019

Done, but I think it already got tested before:

@thomasjm
Copy link
Copy Markdown
Contributor

Ah, I didn't realize lts-2 was doing that. I'm glad we have an explicit recent resolver though.

Thanks again! I'll merge this now. I'd like to get #5 in also and then I'll cut a Hackage release.

@thomasjm thomasjm merged commit 5434c09 into codedownio:master Jun 10, 2019
@thomasjm
Copy link
Copy Markdown
Contributor

(Actually the other one is a breaking change, so I'll release this first.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants