This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Open
Conversation
Member
|
Thanks, @ioana-chiorean! Have you tested this in your local copy? The tests are failing. I will have a look at it tomorrow. |
|
I think It is a better idea to reverse the list when looping it: This will make the following change: |
|
By the way, my previous comment is not logically correct. This will reverse only the first page of events, which will lead to strange results. There are two things that can be done:
Cheers! |
Member
|
@ioana-chiorean Are you able to try the alternatives @RadoRado offered? If you don't have the time, let us know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.