Lab3 corrections made#17
Open
jtwalters25 wants to merge 3 commits intocodefellows-javascript-401d13:masterfrom
Open
Lab3 corrections made#17jtwalters25 wants to merge 3 commits intocodefellows-javascript-401d13:masterfrom
jtwalters25 wants to merge 3 commits intocodefellows-javascript-401d13:masterfrom
Conversation
jalleng
reviewed
Feb 20, 2017
| 'use strict'; | ||
|
|
||
| const fileReader = require('./lib/file-reader.js'); | ||
|
|
There was a problem hiding this comment.
Hey Jeremiah. Is this file 'file-reader.js' in your repo? I am not seeing it and It is throwing an error in my console.
jalleng
reviewed
Feb 20, 2017
|
|
||
| const readFileHelper = module.exports = function(pathArray, callback) { | ||
| var result = []; | ||
|
|
There was a problem hiding this comment.
I like that you are passing in the file paths as an array.
jalleng
reviewed
Feb 20, 2017
| var result = []; | ||
|
|
||
| fs.readFile(pathArray[0], function(err, data) { | ||
| if (err) return callback(err); |
There was a problem hiding this comment.
Good Job returning the error with the callback.
jalleng
reviewed
Feb 20, 2017
| expect(data[2]).to.equal(expectedResult[2]); | ||
| console.log('data', data); | ||
| done(); | ||
| }); |
There was a problem hiding this comment.
This is a good test. It will make sure that your files are coming back in the correct order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.