Open
Conversation
… if that's because of proper asynch management.
…ow funcs and testing results against an array of sequential values
jalleng
reviewed
Feb 19, 2017
|
|
||
| const fileReader = require('./lib/file-reader.js'); | ||
|
|
||
| fileReader.readAllFiles(); |
There was a problem hiding this comment.
You set up your function to take an array of file names and a callback but you aren't passing in any parameters here when you call it. Refactor index.js slightly so that you can call node index.js from the command line and have it print out the data you are looking for. You are really close here!
jalleng
reviewed
Feb 19, 2017
| expect(data[2]).to.equal(expectedResults[2]); | ||
| console.log('data', data); | ||
| done(); | ||
| }); |
There was a problem hiding this comment.
Good job remembering to call done(). Also, this is a good test it will make sure everything is coming back in order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.