04-Bitmap- Zachary-Sugey-Jeremiah#14
04-Bitmap- Zachary-Sugey-Jeremiah#14jtwalters25 wants to merge 36 commits intocodefellows-javascript-401d13:masterfrom
Conversation
Created transform function that doesn't do what we think it should
got the transform function working
refactored transform function - split functions into export files
added command line argument support
Test complete on for components of the bitmap constructor function
added documentation and extra example pics
fixes and proof reading of doc
centering
centering
centering
centering
completed doc! Last Edit
completed doc, for real the final edit !
…s and added error if index is called without transform parameters
bnates
left a comment
bnates
left a comment
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv nice job! i've left some general nitpicky comments in your PR but, overall, y'all did great and it's clear you put in a bunch of time and effort to get this to work.
| "impliedStrict": true | ||
| }, | ||
| "extends": "eslint:recommended" | ||
| } |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv .eslintrc looks good
| # Windows shortcuts | ||
| *.lnk | ||
|
|
||
| # End of https://www.gitignore.io/api/node,osx,windows,linux No newline at end of file |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv .gitignore looks good
| node index.js invert random bluescale grayscale | ||
| ~~~~ | ||
| <br><br> | ||
| [Back to the top](#top) |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv generally speaking, this README and associated documentation looks good - for future projects, i'd like to see more of an emphasis on using modern markdown constructs - i'll work with you on this more as we approach mid-quarter projects
| gulp.watch(['**/*.js', '!node_modules/**'], ['lint', 'test']); | ||
| }); | ||
|
|
||
| gulp.task('default', ['dev']); |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv gulpfile.js looks good
| } | ||
| return | ||
| } | ||
| throw new Error('You must supply a transform command: grayscale, invert, bluescale or random)'); No newline at end of file |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv index file looks good - great job including and implementing command line arguments
| }); | ||
| }; | ||
|
|
||
| exports.write = function(err, data, fileName){ |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv great job encapsulating your writeFile call for reusability
| readWrite.write(null, bitmap, outputFile); | ||
| } | ||
| }); | ||
| }; No newline at end of file |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv transform methods look good - that said, a better approach would be to make these prototype methods of a transform constructor - this is simply a cleaner pattern and makes these methods easier to test and chain
| "gulp-mocha": "^3.0.1", | ||
| "mocha": "^3.2.0" | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv package.json looks good
| }); | ||
|
|
||
| }); | ||
| }); |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv tests look good - nice job checking metadata about the bitmap, including the size and type
| // } | ||
| // }); | ||
| // }); | ||
| // }); |
There was a problem hiding this comment.
@jtwalters25 @zcrumbo @sueanyv large comment blocks should be removed from the master branch - these should be contained on dev branches
4 participants
Bitmap Transformation completed after many challenges.