Will Shiv and Anna#21
Will Shiv and Anna#21WillSkelton wants to merge 29 commits intocodefellows-javascript-401d13:masterfrom daddyshivvy:master
Conversation
all logic sorted out, we chillin
iteration fixes
invert is working
code reduced with buffer.fill()
inverted bitmap writes to file
black and inverted works
creating new buffers for each transform
done for now. a few simple transforms, will think about more complex …
now it works
all tests added and passing
bnates
left a comment
bnates
left a comment
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul y'all killed it!!! great job on this assignment!
| "impliedStrict": true | ||
| }, | ||
| "extends": "eslint:recommended" | ||
| } |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul .eslintrc looks good
| # .nfs files are created when an open file is removed but is still being accessed | ||
| .nfs* | ||
|
|
||
| # End of https://www.gitignore.io/api/node,vim,osx,macos,linux |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul .gitignore looks good
| "impliedStrict": true | ||
| }, | ||
| "extends": "eslint:recommended" | ||
| } |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul duplicate eslintrc???
| # .nfs files are created when an open file is removed but is still being accessed | ||
| .nfs* | ||
|
|
||
| # End of https://www.gitignore.io/api/node,vim,osx,macos,linux |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul same deal here - duplicate .gitignore???
| * ability to handle various sized bitmap | ||
| * ability to handle LE and BE computers with a single if statement | ||
| * utilizes a command line interface (CLI) | ||
| * CLI can select the transforms |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul documentation outlined in your README is excellent - nice job on this
| return redBuf; | ||
| }; | ||
|
|
||
| exports.greyScale = function(bitmap) { |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul the transform methods in this file are really good - that said, they may be better served as prototype methods built on to the constructor - the constructor could hold the raw buffer and the methods could then interact directly with them
all that said, this is still really clean and good
| if (err) throw err; | ||
| }); | ||
|
|
||
| fs.writeFile(`${__dirname}/../img/grey.bmp`, transforms.greyScale(bitmap), function(err, data) { |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul too many nested writeFile calls here - if the transforms were part of a series of prototype methods then you could simply chain them
| "gulp": "^3.9.1", | ||
| "mocha": "^3.2.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul package.json looks as expected
| fileReader(`${__dirname}/../img/black.bmp`, function(err, data) { | ||
| expect(err).to.equal(null); | ||
| // expect(data.toString()).to.be.a('string'); | ||
| expect(data.toString('utf-8').slice(54, 1078)).to.equal('0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000'); |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul hahaha - awesome test
| // describe('turnBlack switches palette to black', function() { | ||
| // it('') | ||
| // }); | ||
| // }); |
There was a problem hiding this comment.
@William-Skelton @shivprogrammer @annaul best to remove unused comment blocks from the master branch - these should be contained in a feature or dev branch
overall, excellent tests - you are testing for appropriate outcomes, which is great - only nitpick would be to extract and cluster these tests into 2 files - this one doesn't follow a really cohesive pattern
4 participants
No description provided.