Open
Conversation
jalleng
reviewed
Mar 1, 2017
| 'use strict'; | ||
|
|
||
| const createError = require('http-errors'); | ||
| const debug = require('debug'); |
There was a problem hiding this comment.
You should add on the debug extension here. ('drink:error-middleware');
jalleng
reviewed
Mar 1, 2017
| };//end deleteItem | ||
|
|
||
|
|
||
| exports.availIDs = function(schemaName){ |
There was a problem hiding this comment.
You should add in your debug lines to these two functions. So you can see if these functions are getting called when you expect them to.
jalleng
reviewed
Mar 1, 2017
|
|
||
| Drink.fetchIDs = function(){ | ||
| debug('fetchIDs'); | ||
| storage.availIDs('drink'); |
jalleng
reviewed
Mar 1, 2017
| expect(res.status).to.equal(200); | ||
| expect(res.body.id).to.equal(this.tempDrink.id); | ||
| expect(res.body.name).to.equal(this.tempDrink.name); | ||
| expect(res.body.content).to.equal(this.tempDrink.content); |
There was a problem hiding this comment.
Make sure you are checking for the properties that you set on the tempDrink.
jalleng
reviewed
Mar 1, 2017
| if(err) return done(err); | ||
| expect(res.status).to.equal(200); | ||
| expect(res.body.name).to.equal(exampleDrink.name); | ||
| expect(res.body.content).to.equal(exampleDrink.content); |
There was a problem hiding this comment.
Same as above. Does your exampleDrink have a 'content' property?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.