Enhance analytics tracking and documentation closes #45

[aliirz]

• Added Google Analytics integration for improved user behavior tracking.
• Implemented view trackers for bills, constitution, and proceedings to monitor user engagement.
• Updated the batch ingestion script to include a limit option for processing files, enhancing flexibility in document handling.
• Introduced new types for advanced RAG system, including chunk and agent definitions, to support upcoming features.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
numainda	Ready	Preview, Comment	Jan 1, 2026 7:39am

[claude]

Pull Request Review: Enhance analytics tracking and documentation

Summary: This PR adds Google Analytics integration, page view tracking, batch ingestion enhancements, and TypeScript types for Phase 2 RAG system. Good code quality overall with some security and cleanup concerns.

---

Security Concerns

CRITICAL - Exposed GA Measurement ID:

• Location: lib/analytics.ts:13, components/google-analytics.tsx:4
• Issue: Hardcoded GA measurement ID
• Recommendation: Use environment variable for consistency

PII in Analytics:

• Location: lib/analytics.ts:42-82
• Issue: Tracking potentially sensitive data (thread IDs, search queries)
• Recommendation: Ensure compliance with privacy regulations, consider anonymizing identifiers, add user consent management

---

Bugs and Issues

1. Missing Error Handling

• Location: lib/analytics.ts:16-37
• Issue: No error handling if window.gtag fails
• Fix: Wrap tracking calls in try-catch blocks

2. Type Safety Issue

• Location: app/chat/page.tsx:255,270
• Issue: trackChatMessage passes undefined when threadId is null
• Fix: Update function signature to handle null/undefined

3. Batch Ingest Validation

• Location: scripts/batch-ingest.ts:414
• Issue: No validation for parseInt (could return NaN)
• Fix: Add validation for --limit parameter

---

Code Quality

Positives:

• Consistent naming conventions
• Well-structured TypeScript types
• Good separation of concerns
• Proper use of client components
• Comprehensive Phase 2 documentation

Issues:

1. Unused trackPageView function (lib/analytics.ts:15-21)
2. package.json.backup should not be committed
3. tsconfig.tsbuildinfo should not be committed
4. No tests for analytics functions

---

Recommendations

Must Fix Before Merge:

1. Remove package.json.backup and tsconfig.tsbuildinfo
2. Add input validation for --limit parameter
3. Add error handling to analytics functions
4. Address privacy/consent considerations

Should Fix:

1. Move GA ID to environment variable
2. Fix trackChatMessage type safety
3. Remove unused trackPageView or implement it
4. Add unit tests

Nice to Have:

1. Progress indicators for batch ingestion
2. Analytics opt-out mechanism

---

Conclusion

Good PR with valuable features. Requires changes for security/privacy concerns and cleanup of committed artifacts before merging.

Files needing attention:

• lib/analytics.ts (error handling, privacy)
• scripts/batch-ingest.ts:414 (validation)
• package.json.backup (remove)
• tsconfig.tsbuildinfo (remove)