Drop legacy plexus API and use only JSR330 components by cstamas · Pull Request #220 · codehaus-plexus/plexus-archiver

cstamas · 2022-06-21T11:44:08Z

Drop:

plexus container default
legacy plexus APIs like Contextualizable
drop Plexus Logger uses
some minor cleanups for Java8 level
converted Plexus XML to JSR330
dropped plexus container (so no pcd or shim) as it is not needed anymore, plexus-io is not plx anymore as well

This is a breaking change (for example Plexus vs Slf4j logger use on APIs), so version bump is imminent.

Drop: - plexus container default - legacy plexus APIs like Contextualizable - drop Plexus Logger uses - some minor cleanups for Java8 level - converted Plexus XML to JSR330

sonatype-lift · 2022-06-21T11:46:33Z


 /**
 *
 * @author philip.lourandos


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T11:46:34Z

@@ -32,6 +34,7 @@
 /**
 * @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T11:46:36Z

-
-    public static final String ROLE_HINT = "jar-security";
-
    public static final String[] SECURITY_FILE_PATTERNS =


MutablePublicArray: Non-empty arrays are mutable, so this public static final array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T11:46:37Z

@@ -26,6 +28,7 @@
 * @author philiplourandos


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T11:46:39Z


 /**
 *
 * @author philip.lourandos


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T11:46:41Z

 import org.codehaus.plexus.util.SelectorUtils;

 /**
 * @since 1.0-alpha-9


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T11:46:42Z

+import static java.util.Objects.requireNonNull;
+
 /**
 * @author dantran


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T11:46:43Z

 import java.io.File;

 /**
 * @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

cstamas · 2022-06-21T11:56:49Z

@sonatype-lift zip it

sonatype-lift · 2022-06-21T12:01:00Z

+import org.slf4j.Logger;

 /**
 * @author Olivier Lamy


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

michael-o · 2022-06-21T12:07:46Z

 import java.io.File;

+// TODO: Name is okay? Seems not
+@Named( "snappy.gz" )


this look totally wrong. I'd expect tar.snappy

All this comes from (under maintained) plexus XML file, there was even par vs Par

plexus-archiver/src/main/resources/META-INF/plexus/components.xml

Line 183 in 337214c

<role-hint>par</role-hint>

plexus-archiver/src/main/resources/META-INF/plexus/components.xml

Line 378 in 337214c

<role-hint>Par</role-hint>

plexus-archiver/src/main/resources/META-INF/plexus/components.xml

Line 405 in 337214c

<role-hint>snappy.gz</role-hint>

michael-o · 2022-06-21T12:08:09Z

 * Extract files in tar with snappy compression
 *
 */
+@Named( "tar.snappy" )


this one is correct

sonatype-lift · 2022-06-21T12:52:12Z

@@ -32,6 +34,7 @@
 /**
 * @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T12:57:42Z

@@ -32,6 +34,7 @@
 * @author philip.lourandos


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-21T12:57:44Z

@@ -46,6 +48,7 @@
 /**
 * @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

As plexusIO carries no more Plexus components but SISU components.

michael-o · 2022-06-22T09:20:36Z

-                return s1.compareTo( s2 );
-            }
-        } );
+        setFilenameComparator( String::compareTo );


sonatype-lift · 2022-06-23T09:21:13Z

@@ -29,6 +31,7 @@
 * @author lore


MissingSummary: A summary line is required on public/protected Javadocs.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

cstamas added 2 commits June 21, 2022 13:42

Drop legacy

94d29ac

Drop: - plexus container default - legacy plexus APIs like Contextualizable - drop Plexus Logger uses - some minor cleanups for Java8 level - converted Plexus XML to JSR330

Drop empty XML

604fd18

cstamas self-assigned this Jun 21, 2022

sonatype-lift Bot reviewed Jun 21, 2022

View reviewed changes

Move all container to test

22c4a8e

sonatype-lift Bot reviewed Jun 21, 2022

View reviewed changes

michael-o requested changes Jun 21, 2022

View reviewed changes

Set proper scope

d50bef1

sonatype-lift Bot reviewed Jun 21, 2022

View reviewed changes

Remove redundant method, is in superclass of alias

aa97010

sonatype-lift Bot reviewed Jun 21, 2022

View reviewed changes

cstamas requested a review from michael-o June 21, 2022 13:04

cstamas added 2 commits June 21, 2022 15:27

Fix name

a49d3d1

Drop plexus alltogether, is not needed anymore

bef6e15

As plexusIO carries no more Plexus components but SISU components.

michael-o reviewed Jun 22, 2022

View reviewed changes

michael-o self-requested a review June 22, 2022 09:44

michael-o approved these changes Jun 22, 2022

View reviewed changes

olamy added the enhancement label Jun 23, 2022

olamy changed the title ~~Drop legacy~~ Drop legacy plexus API and use only JSR330 components Jun 23, 2022

Update to released plexus-io

927388a

sonatype-lift Bot reviewed Jun 23, 2022

View reviewed changes

cstamas merged commit 48d3280 into master Jun 23, 2022

cstamas deleted the drop-legacy branch June 23, 2022 09:34

valfirst mentioned this pull request Jul 25, 2022

Bump plexus-archiver to 4.4.0 saucelabs/ci-sauce#127

Merged

jorsol mentioned this pull request Sep 12, 2022

Bump plexus-archiver from 4.2.2 to 4.4.0 apache/maven-dependency-plugin#223

Closed

		@@ -32,6 +34,7 @@
		/**
		* @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>


		public static final String ROLE_HINT = "jar-security";

		public static final String[] SECURITY_FILE_PATTERNS =

		@@ -46,6 +48,7 @@
		/**
		* @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>

Conversation

cstamas commented Jun 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

cstamas commented Jun 21, 2022

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

michael-o Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

cstamas Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

cstamas Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

cstamas Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

michael-o Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

michael-o Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

michael-o Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift Bot Jun 23, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cstamas commented Jun 21, 2022 •

edited

Loading