Skip to content

Fix: Toolbar. ciDebugBar.showTab() context.#5554

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
iRedds:fix/toolbar
Jan 7, 2022
Merged

Fix: Toolbar. ciDebugBar.showTab() context.#5554
paulbalandan merged 1 commit intocodeigniter4:developfrom
iRedds:fix/toolbar

Conversation

@iRedds
Copy link
Collaborator

@iRedds iRedds commented Jan 7, 2022

Description
Follow-up #5544
Calling the showTab method changes the context if the method is not called directly, but as an "internal call".
Rollback of previous changes.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 7, 2022
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked. Thanks!

@kenjis kenjis added the hotfix label Jan 7, 2022
@paulbalandan paulbalandan merged commit a09f7d9 into codeigniter4:develop Jan 7, 2022
kenjis pushed a commit that referenced this pull request Jan 8, 2022
Fix: Toolbar. ciDebugBar.showTab() context.
@kenjis kenjis mentioned this pull request Jan 8, 2022
8 tasks
@iRedds iRedds deleted the fix/toolbar branch January 8, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them hotfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants