docs: Add @method for when() and whenNot() in models.#7836
Merged
kenjis merged 4 commits intocodeigniter4:developfrom Aug 21, 2023
Merged
docs: Add @method for when() and whenNot() in models.#7836kenjis merged 4 commits intocodeigniter4:developfrom
@method for when() and whenNot() in models.#7836kenjis merged 4 commits intocodeigniter4:developfrom
Conversation
ddevsr
approved these changes
Aug 17, 2023
kenjis
reviewed
Aug 18, 2023
kenjis
reviewed
Aug 18, 2023
kenjis
reviewed
Aug 18, 2023
kenjis
reviewed
Aug 18, 2023
when() and whenNot() in models.@method for when() and whenNot() in models.
MGatner
approved these changes
Aug 20, 2023
Member
MGatner
left a comment
There was a problem hiding this comment.
Looks good! Rector failure is a mistake - rerunning.
kenjis
approved these changes
Aug 21, 2023
Member
|
@sammyskills Thank you. We recommend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
when()andwhenNot()conditional statements works directly with models, i.e., one does not need to call thebuilder()method before using it. So, they should be type-hinted in IDEs or code editors, just like others.See https://forum.codeigniter.com/showthread.php?tid=88190&pid=411611#pid411611
Checklist: