fix: add error handling for corrupted cache files in FileHandler#9586
Merged
michalsn merged 1 commit intocodeigniter4:developfrom May 31, 2025
Merged
fix: add error handling for corrupted cache files in FileHandler#9586michalsn merged 1 commit intocodeigniter4:developfrom
FileHandler#9586michalsn merged 1 commit intocodeigniter4:developfrom
Conversation
ddevsr
approved these changes
May 28, 2025
|
can you add error log. when content is false |
Member
Author
|
Since this is a caching library, corrupted or unreadable files are expected edge cases, and logging every occurrence could easily flood logs in high-traffic environments. Silent failure is acceptable here, as cache misses are non-critical by design. |
paulbalandan
approved these changes
May 30, 2025
Member
Author
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
FileHandler::getItem()method to gracefully manage corrupted or malformed cache files that cannot be read or unserialized.unserialize()is now wrapped in a try/catch block, since it may throw aThrowablethat the@operator cannot suppressfile_get_contents()andunlink()are prefixed with @ to suppress warnings, as these functions only emit warnings and do not throw exceptionsFixes #9573
Checklist: