Skip to content

refactor: remove unneeded Entities\Cast\IntBoolCast#1188

Merged
datamweb merged 1 commit intocodeigniter4:developfrom
grimpirate:develop
Aug 27, 2024
Merged

refactor: remove unneeded Entities\Cast\IntBoolCast#1188
datamweb merged 1 commit intocodeigniter4:developfrom
grimpirate:develop

Conversation

@grimpirate
Copy link
Contributor

Description
Reopening of Pull Requests: #1186, #1187

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 27, 2024
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your conversations and I truly appreciate the effort you've put into the research and review. I'm glad to see that everything looks good in terms of backward compatibility. Thank you again for your thorough and professional work!

@datamweb datamweb merged commit 43add5a into codeigniter4:develop Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants