fix: withPermissions() for users without permissions#1290
Merged
datamweb merged 1 commit intocodeigniter4:developfrom Oct 8, 2025
Merged
fix: withPermissions() for users without permissions#1290datamweb merged 1 commit intocodeigniter4:developfrom
withPermissions() for users without permissions#1290datamweb merged 1 commit intocodeigniter4:developfrom
Conversation
5 tasks
Contributor
|
I can confirm that upon implementing these changes in the code Bonfire2 user list does not make lazy loading database queries for permissions. Query number got down from 25 to 10. |
datamweb
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug affecting
UserModel::withPermissions(), which caused users without permissions to trigger additional, unnecessary database queries. The same behavior was implemented for theUserModel::withGroups()for unification.Bug reported here: #1257 (comment)
Checklist: